Skip to content

Upgrade uv so that exclude-newer = "7 days" works#1020

Closed
brendan-priorlabs wants to merge 1 commit into
mainfrom
brendan/fix-uv-version
Closed

Upgrade uv so that exclude-newer = "7 days" works#1020
brendan-priorlabs wants to merge 1 commit into
mainfrom
brendan/fix-uv-version

Conversation

@brendan-priorlabs

Copy link
Copy Markdown
Contributor

No description provided.

@brendan-priorlabs brendan-priorlabs requested a review from a team as a code owner June 9, 2026 13:44
@brendan-priorlabs brendan-priorlabs requested review from oscarkey and removed request for a team June 9, 2026 13:44

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds uv>=0.11.7 to the CI dependencies in pyproject.toml. The reviewer pointed out that this version of uv does not exist, which will cause dependency resolution to fail, and suggested using a valid version like 0.5.0. Additionally, the reviewer noted that uv's exclude-newer option requires an absolute RFC 3339 timestamp rather than a relative duration.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread pyproject.toml
@oscarkey oscarkey added the no changelog needed PR does not require a changelog entry label Jun 9, 2026

@oscarkey oscarkey left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm for uv change, not sure why ci is failing though

@oscarkey

oscarkey commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

hoping I've fixed it in #1027

@oscarkey

Copy link
Copy Markdown
Contributor

I think it's safe to close this PR. Looking at a recent run on main: https://github.com/PriorLabs/TabPFN/actions/runs/28363957214/job/84025180512

  • The "Install uv" step installs version 0.11.25
  • The "Install dependencies" step doesn't install uv
  • We don't activate the venv, we use uv run, which should call the system uv not the uv in the venv?

But let me know if I'm missing something and we can merge ofc.

@oscarkey oscarkey closed this Jun 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no changelog needed PR does not require a changelog entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants