New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run tests with Wikibase master #19

Open

JeroenDeDauw opened this issue Jan 23, 2022 · 1 comment

Labels

Member

JeroenDeDauw commented Jan 23, 2022

Don't know what is causing the error https://github.com/ProfessionalWiki/WikibaseEdtf/runs/4913925133?check_suite_focus=true

@addshore any idea? LocalSettings.php loading code is at https://github.com/ProfessionalWiki/WikibaseEdtf/blob/master/.github/workflows/installMediaWiki.sh

JeroenDeDauw added the help wanted label

Member Author

JeroenDeDauw commented Nov 9, 2022

use Wikibase\DataModel\Entity\NumericPropertyId;
use Wikibase\DataModel\Entity\PropertyId;

class Compat {

	public static function newPId( string $id ): PropertyId {
		if ( class_exists( NumericPropertyId::class ) ) {
			return new NumericPropertyId( $id );
		}

		return new PropertyId( $id );
	}

}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment