Skip to content

Commit 72b731a

Browse files
committed
This closes qax-os#2132, fix a v2.9.1 regression bug introduced by commit ce9061f
- Update GitHub Action configuration for test build on ARM
1 parent 4180c20 commit 72b731a

File tree

2 files changed

+11
-2
lines changed

2 files changed

+11
-2
lines changed

.github/workflows/go.yml

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,15 @@ jobs:
2828
- name: Build
2929
run: go build -v .
3030

31+
- name: Build on ARM
32+
if: runner.os == 'Linux'
33+
run: |
34+
GOARCH=arm GOARM=5 go build .
35+
GOARCH=arm GOARM=6 go build .
36+
GOARCH=arm GOARM=7 go build .
37+
GOARCH=arm64 go build .
38+
GOARCH=arm64 GOOS=android go build .
39+
3140
- name: Test
3241
run: env GO111MODULE=on go test -v -timeout 50m -race ./... -coverprofile='coverage.txt' -covermode=atomic
3342

file.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -211,7 +211,7 @@ func (f *File) writeToZip(zw *zip.Writer) error {
211211
break
212212
}
213213
content, _ := f.Pkg.Load(path)
214-
if n, err = fi.Write(content.([]byte)); n > math.MaxUint32 {
214+
if n, err = fi.Write(content.([]byte)); int64(n) > math.MaxUint32 {
215215
f.zip64Entries = append(f.zip64Entries, path)
216216
}
217217
}
@@ -228,7 +228,7 @@ func (f *File) writeToZip(zw *zip.Writer) error {
228228
if fi, err = zw.Create(path); err != nil {
229229
break
230230
}
231-
if n, err = fi.Write(f.readBytes(path)); n > math.MaxUint32 {
231+
if n, err = fi.Write(f.readBytes(path)); int64(n) > math.MaxUint32 {
232232
f.zip64Entries = append(f.zip64Entries, path)
233233
}
234234
}

0 commit comments

Comments
 (0)