Skip to content

Commit 3701b6f

Browse files
committed
Suppress mypy errors in field tracker tests
I can't find a way to inform mypy of the actual types without duplicating a lot of test code.
1 parent ce29741 commit 3701b6f

File tree

1 file changed

+6
-5
lines changed

1 file changed

+6
-5
lines changed

tests/test_fields/test_field_tracker.py

+6-5
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,8 @@ def setUp(self) -> None:
9797
self.tracker = self.instance.tracker
9898

9999
def test_descriptor(self) -> None:
100-
self.assertTrue(isinstance(self.tracked_class.tracker, FieldTracker))
100+
tracker = self.tracked_class.tracker # type: ignore[call-overload]
101+
self.assertTrue(isinstance(tracker, FieldTracker))
101102

102103
def test_pre_save_changed(self) -> None:
103104
self.assertChanged(name=None)
@@ -529,14 +530,14 @@ class FieldTrackerForeignKeyMixin(FieldTrackerMixin):
529530

530531
def setUp(self) -> None:
531532
self.old_fk = self.fk_class.objects.create(number=8)
532-
self.instance = self.tracked_class.objects.create(fk=self.old_fk)
533+
self.instance = self.tracked_class.objects.create(fk=self.old_fk) # type: ignore[misc]
533534

534535
def test_default(self) -> None:
535536
self.tracker = self.instance.tracker
536537
self.assertChanged()
537538
self.assertPrevious()
538539
self.assertCurrent(id=self.instance.id, fk_id=self.old_fk.id)
539-
self.instance.fk = self.fk_class.objects.create(number=8)
540+
self.instance.fk = self.fk_class.objects.create(number=8) # type: ignore[assignment]
540541
self.assertChanged(fk_id=self.old_fk.id)
541542
self.assertPrevious(fk_id=self.old_fk.id)
542543
self.assertCurrent(id=self.instance.id, fk_id=self.instance.fk_id)
@@ -546,7 +547,7 @@ def test_custom(self) -> None:
546547
self.assertChanged()
547548
self.assertPrevious()
548549
self.assertCurrent(fk_id=self.old_fk.id)
549-
self.instance.fk = self.fk_class.objects.create(number=8)
550+
self.instance.fk = self.fk_class.objects.create(number=8) # type: ignore[assignment]
550551
self.assertChanged(fk_id=self.old_fk.id)
551552
self.assertPrevious(fk_id=self.old_fk.id)
552553
self.assertCurrent(fk_id=self.instance.fk_id)
@@ -558,7 +559,7 @@ def test_custom_without_id(self) -> None:
558559
self.assertChanged()
559560
self.assertPrevious()
560561
self.assertCurrent(fk=self.old_fk.id)
561-
self.instance.fk = self.fk_class.objects.create(number=8)
562+
self.instance.fk = self.fk_class.objects.create(number=8) # type: ignore[assignment]
562563
self.assertChanged(fk=self.old_fk.id)
563564
self.assertPrevious(fk=self.old_fk.id)
564565
self.assertCurrent(fk=self.instance.fk_id)

0 commit comments

Comments
 (0)