Skip to content

Commit 8f0b4ee

Browse files
committed
Suppress mypy errors in field tracker tests
I can't find a way to inform mypy of the actual types without duplicating a lot of test code.
1 parent 3c31423 commit 8f0b4ee

File tree

1 file changed

+6
-5
lines changed

1 file changed

+6
-5
lines changed

tests/test_fields/test_field_tracker.py

+6-5
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,8 @@ def setUp(self) -> None:
9696
self.tracker = self.instance.tracker
9797

9898
def test_descriptor(self) -> None:
99-
self.assertTrue(isinstance(self.tracked_class.tracker, FieldTracker))
99+
tracker = self.tracked_class.tracker
100+
self.assertTrue(isinstance(tracker, FieldTracker))
100101

101102
def test_pre_save_changed(self) -> None:
102103
self.assertChanged(name=None)
@@ -528,14 +529,14 @@ class FieldTrackerForeignKeyMixin(FieldTrackerMixin):
528529

529530
def setUp(self) -> None:
530531
self.old_fk = self.fk_class.objects.create(number=8)
531-
self.instance = self.tracked_class.objects.create(fk=self.old_fk)
532+
self.instance = self.tracked_class.objects.create(fk=self.old_fk) # type: ignore[misc]
532533

533534
def test_default(self) -> None:
534535
self.tracker = self.instance.tracker
535536
self.assertChanged()
536537
self.assertPrevious()
537538
self.assertCurrent(id=self.instance.id, fk_id=self.old_fk.id)
538-
self.instance.fk = self.fk_class.objects.create(number=8)
539+
self.instance.fk = self.fk_class.objects.create(number=8) # type: ignore[assignment]
539540
self.assertChanged(fk_id=self.old_fk.id)
540541
self.assertPrevious(fk_id=self.old_fk.id)
541542
self.assertCurrent(id=self.instance.id, fk_id=self.instance.fk_id)
@@ -545,7 +546,7 @@ def test_custom(self) -> None:
545546
self.assertChanged()
546547
self.assertPrevious()
547548
self.assertCurrent(fk_id=self.old_fk.id)
548-
self.instance.fk = self.fk_class.objects.create(number=8)
549+
self.instance.fk = self.fk_class.objects.create(number=8) # type: ignore[assignment]
549550
self.assertChanged(fk_id=self.old_fk.id)
550551
self.assertPrevious(fk_id=self.old_fk.id)
551552
self.assertCurrent(fk_id=self.instance.fk_id)
@@ -557,7 +558,7 @@ def test_custom_without_id(self) -> None:
557558
self.assertChanged()
558559
self.assertPrevious()
559560
self.assertCurrent(fk=self.old_fk.id)
560-
self.instance.fk = self.fk_class.objects.create(number=8)
561+
self.instance.fk = self.fk_class.objects.create(number=8) # type: ignore[assignment]
561562
self.assertChanged(fk=self.old_fk.id)
562563
self.assertPrevious(fk=self.old_fk.id)
563564
self.assertCurrent(fk=self.instance.fk_id)

0 commit comments

Comments
 (0)