Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pyo3 0.22 Support #11

Closed
Zheaoli opened this issue Oct 22, 2024 · 6 comments
Closed

pyo3 0.22 Support #11

Zheaoli opened this issue Oct 22, 2024 · 6 comments

Comments

@Zheaoli
Copy link

Zheaoli commented Oct 22, 2024

🐛 Bug Reports

apache/opendal#5224

In some third party library, we are trying to support Python 3.13. we need update the PyO3 to a version larger than 0.22

For now, https://crates.io/crates/pyo3-async-runtimes/0.21.0/dependencies this lib is lock pyo3 to 0.21

So, Should we consider update the pyo3-async-runtimes to 0.22.x support?

@cpu
Copy link

cpu commented Oct 22, 2024

👋 I was also looking into this recently.

0.22 support was merged to main in #7, however the documentation still needs updating and the Cargo.toml version bumped for a proper release (see #9).

You could use a Cargo patch in the meantime:

[patch.crates-io]
# TODO(XXX): remove once pyo3-async-runtimes cuts a 0.22 release.
pyo3-async-runtimes  = { git = 'https://github.com/PyO3/pyo3-async-runtimes.git', rev = '284bd36d0426a988026f878cae22abdb179795e6' }

@Zheaoli
Copy link
Author

Zheaoli commented Oct 22, 2024

May I ask when will the project release the next version? I think I can not lock the version by using git hash in the upstream repo.

@kylebarron
Copy link
Contributor

You should be able to use the git hash, at least until you plan to publish to crates.io next.

Otherwise, I think we all hope for a new release soon

@Xuanwo
Copy link

Xuanwo commented Oct 24, 2024

You should be able to use the git hash, at least until you plan to publish to crates.io next.

Yes, those are exactly our cases.

Is there anything we can help with?

@davidhewitt
Copy link
Member

Release is now published! I'm sure there's plenty of things which can be tweaked / improved in this new fork, however I think best to get a working version for PyO3 0.22 out so that people can get on with upgrading and we can iterate from there :)

@Xuanwo
Copy link

Xuanwo commented Oct 28, 2024

Release is now published! I'm sure there's plenty of things which can be tweaked / improved in this new fork, however I think best to get a working version for PyO3 0.22 out so that people can get on with upgrading and we can iterate from there :)

That's really great, thank you for your efforts!

@Zheaoli Zheaoli closed this as completed Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants