Skip to content
This repository has been archived by the owner on Jun 25, 2018. It is now read-only.

implement Socket.setsockopt() #23

Open
fafhrd91 opened this issue May 5, 2017 · 5 comments
Open

implement Socket.setsockopt() #23

fafhrd91 opened this issue May 5, 2017 · 5 comments

Comments

@fafhrd91
Copy link
Collaborator

fafhrd91 commented May 5, 2017

we need this for some options, like TCP_NODELAY, TCP_CORK, SO_KEEPALIVE

@1st1
Copy link

1st1 commented May 5, 2017

NODELAY should be set by default btw.

@fafhrd91
Copy link
Collaborator Author

fafhrd91 commented May 5, 2017

But if we start mixing it with CORK, then we need to turn it off?

@asvetlov added this cork and nodelay manipulation to aiohttp

@1st1
Copy link

1st1 commented May 5, 2017

Well, asyncio in Python 3.6 (and 3.5.3) sets NODELAY by default and so should we. It's really up to those who use advanced TCP settings to workaround that.

@1st1
Copy link

1st1 commented May 5, 2017

Moreover, I hope we can use (eventually) vectorized writes in tokio.Transport.write() and .writelines(), which should cover use cases for CORK.

@fafhrd91
Copy link
Collaborator Author

fafhrd91 commented May 5, 2017

btw we need to add tests for Transport, uvloop doesn't contain tests for "writelines()" for example

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants