Fix currency formatting (#7723)

* Replace currency string formatting with Lean currency symbols.

Also clean up orders tags from having redundant information.

* Setting default order tag only after price currency is properly set

* Minor fixes and new unit tests

* Minor fixes

Author: jhonabreul

Algorithm.CSharp/AddBetaIndicatorRegressionAlgorithm.cs

@@ -138,7 +138,7 @@ public override void OnOrderEvent(OrderEvent orderEvent)
             {"Estimated Strategy Capacity", "$35000000.00"},
             {"Lowest Capacity Asset", "IBM R735QTJ8XC9X"},
             {"Portfolio Turnover", "1.51%"},
-            {"OrderListHash", "e930f95771bc50dd2db1c353e054c4e7"}
+            {"OrderListHash", "381bb9310f9dceb8a79a56849789bdab"}
         };
     }
 }

Algorithm.CSharp/BasicTemplateCryptoAlgorithm.cs

@@ -237,7 +237,7 @@ public override void OnEndOfAlgorithm()
             {"Estimated Strategy Capacity", "$0"},
             {"Lowest Capacity Asset", "BTCEUR 2XR"},
             {"Portfolio Turnover", "118.08%"},
-            {"OrderListHash", "551b20736f4558a5af5c02b84451fb77"}
+            {"OrderListHash", "77458586d24f1cd00623d63da8279be2"}
         };
     }
 }

Algorithm.CSharp/BybitCryptoRegressionAlgorithm.cs

@@ -166,7 +166,7 @@ public override void OnEndOfAlgorithm()
             {"Estimated Strategy Capacity", "₮560000.00"},
             {"Lowest Capacity Asset", "BTCUSDT 2UZ"},
             {"Portfolio Turnover", "44.04%"},
-            {"OrderListHash", "fb30d137fffe2bc4195d261f0f195b69"}
+            {"OrderListHash", "b3a9eb7392ba1eb7eb0cc387f7382b6c"}
         };
     }
 }

Algorithm.CSharp/CancelOpenOrdersRegressionAlgorithm.cs

@@ -161,7 +161,7 @@ public override void OnEndOfAlgorithm()
             {"Estimated Strategy Capacity", "$370000.00"},
             {"Lowest Capacity Asset", "ETHUSD 2XR"},
             {"Portfolio Turnover", "104.59%"},
-            {"OrderListHash", "bd538acb61fa1fd91732212664c9bbed"}
+            {"OrderListHash", "ec714d818fa30597e992d4c6e939e68c"}
         };
     }
 }

Algorithm.CSharp/ContinuousFutureLimitIfTouchedOrderRegressionAlgorithm.cs

@@ -114,7 +114,7 @@ public override void OnEndOfAlgorithm()
             {"Estimated Strategy Capacity", "$2600000000.00"},
             {"Lowest Capacity Asset", "ES VMKLFZIH2MTD"},
             {"Portfolio Turnover", "16.49%"},
-            {"OrderListHash", "a8b0528aa2c4c2b8f013a06104ddb1d0"}
+            {"OrderListHash", "a83211606af7216647acfd9b5f6907a5"}
         };
     }
 }

Algorithm.CSharp/ExtendedMarketTradingRegressionAlgorithm.cs

@@ -136,7 +136,7 @@ public bool InMarketHours()
             {"Estimated Strategy Capacity", "$14000000.00"},
             {"Lowest Capacity Asset", "SPY R735QTJ8XC9X"},
             {"Portfolio Turnover", "1.44%"},
-            {"OrderListHash", "730d1d797bbe9449a6dc123990f5bd4b"}
+            {"OrderListHash", "1ebbd6a077af944e04ee437a5219eef4"}
         };
     }
 }

Algorithm.CSharp/FutureStopMarketOrderOnExtendedHoursRegressionAlgorithm.cs

@@ -149,7 +149,7 @@ public override void OnEndOfAlgorithm()
             {"Estimated Strategy Capacity", "$3400000.00"},
             {"Lowest Capacity Asset", "ES VMKLFZIH2MTD"},
             {"Portfolio Turnover", "138.95%"},
-            {"OrderListHash", "c85997dd5b7d9acda46ac9d11dd1a039"}
+            {"OrderListHash", "b26a8ad66a8dc5af768a22fbf9a80cec"}
         };
     }
 }

Algorithm.CSharp/LimitFillRegressionAlgorithm.cs

@@ -114,7 +114,7 @@ public override void OnOrderEvent(OrderEvent orderEvent)
             {"Estimated Strategy Capacity", "$180000000.00"},
             {"Lowest Capacity Asset", "SPY R735QTJ8XC9X"},
             {"Portfolio Turnover", "9.86%"},
-            {"OrderListHash", "14eaea4041585a9110df4b5861793f9e"}
+            {"OrderListHash", "a5363ad9b8119f0e256a48efdc7acbb5"}
         };
     }
 }

Algorithm.CSharp/LimitIfTouchedRegressionAlgorithm.cs

@@ -35,9 +35,9 @@ public class LimitIfTouchedRegressionAlgorithm : QCAlgorithm, IRegressionAlgorit
         // We assert the following occur in FIFO order in OnOrderEvent
         private readonly Queue<string> _expectedEvents = new Queue<string>(new[]
         {
-            "Time: 10/10/2013 13:31:00 OrderID: 72 EventID: 399 Symbol: SPY Status: Filled Quantity: -1 FillQuantity: -1 FillPrice: 144.6434 USD LimitPrice: 144.3551 TriggerPrice: 143.61 OrderFee: 1 USD",
-            "Time: 10/10/2013 15:57:00 OrderID: 73 EventID: 156 Symbol: SPY Status: Filled Quantity: -1 FillQuantity: -1 FillPrice: 145.6636 USD LimitPrice: 145.6434 TriggerPrice: 144.89 OrderFee: 1 USD",
-            "Time: 10/11/2013 15:37:00 OrderID: 74 EventID: 380 Symbol: SPY Status: Filled Quantity: -1 FillQuantity: -1 FillPrice: 146.7185 USD LimitPrice: 146.6723 TriggerPrice: 145.92 OrderFee: 1 USD"        });
+            "Time: 10/10/2013 13:31:00 OrderID: 72 EventID: 399 Symbol: SPY Status: Filled Quantity: -1 FillQuantity: -1 FillPrice: $144.6434 LimitPrice: $144.3551 TriggerPrice: $143.61 OrderFee: 1 USD",
+            "Time: 10/10/2013 15:57:00 OrderID: 73 EventID: 156 Symbol: SPY Status: Filled Quantity: -1 FillQuantity: -1 FillPrice: $145.6636 LimitPrice: $145.6434 TriggerPrice: $144.89 OrderFee: 1 USD",
+            "Time: 10/11/2013 15:37:00 OrderID: 74 EventID: 380 Symbol: SPY Status: Filled Quantity: -1 FillQuantity: -1 FillPrice: $146.7185 LimitPrice: $146.6723 TriggerPrice: $145.92 OrderFee: 1 USD"        });
 
         /// <summary>
         /// Initialise the data and resolution required, as well as the cash and start-end dates for your algorithm. All algorithms must initialized.
@@ -74,10 +74,10 @@ public override void OnData(Slice data)
                     $"LIT - Quantity: {_negative * 10}");
                 _request = Transactions.AddOrder(orderRequest);
                 return;
-                
+
             }
 
-            // Order updating if request exists 
+            // Order updating if request exists
             if (_request != null)
             {
                 if (_request.Quantity == 1)
@@ -105,7 +105,7 @@ public override void OnOrderEvent(OrderEvent orderEvent)
 
                 if (orderEvent.ToString() != expected)
                 {
-                    throw new Exception($"orderEvent {orderEvent.Id} differed from {expected}");
+                    throw new Exception($"orderEvent {orderEvent.Id} differed from {expected}. Actual {orderEvent}");
                 }
             }
         }

Algorithm.CSharp/LimitOrdersAreFilledAfterHoursForFuturesRegressionAlgorithm.cs

@@ -149,7 +149,7 @@ public override void OnOrderEvent(OrderEvent orderEvent)
             {"Estimated Strategy Capacity", "$39000000.00"},
             {"Lowest Capacity Asset", "ES VMKLFZIH2MTD"},
             {"Portfolio Turnover", "33.59%"},
-            {"OrderListHash", "170df706887bac7764441b9368887a1d"}
+            {"OrderListHash", "8b3baab1411a6db34780601bdd68ef9e"}
         };
     }
 }