Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor generator to use configuration to load sources and filters #6

Open
C-SELLERS opened this issue Feb 11, 2022 · 0 comments
Open

Comments

@C-SELLERS
Copy link
Contributor

C-SELLERS commented Feb 11, 2022

This stubs generator is very powerful specifically in its parsing of source files and generation of stubs. However, in its current implementation the driving program is limited in that it is set to support specific repos (QC/Lean repo, and dotnet/Runtime repo). Where search patterns and filters are hardcoded into the program.

I believe with some modification to the driving program we could easily support a configurable generic approach to loading in repos (and accompanying filters/search patterns) to be added to the stubs.

This isn't critical to its functionality that it serves for QC but it would open up the applications for this software significantly.

In example, we recently merged a workaround for Lean stubs generation where I load in additional DataSource repos inside of the Lean repo I pass to the generator. This added all of our DataSource sets the to stubs. This is great, but it was a hacky workaround that required a PR on both LEAN and this Repo to hardcode the addition of those repos and the filtering.

See this for that example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant