Skip to content

Refactor contents listing #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 24, 2024
Merged

Conversation

DenisaCG
Copy link
Member

@DenisaCG DenisaCG commented May 22, 2024

Refactored the listing of contents in the get function by extracting the content at that directory level and displaying it. Adapted the delete and copy functionalities to work the same way - in order to eliminate corner cases brought by different file paths.

@DenisaCG DenisaCG self-assigned this May 22, 2024
@DenisaCG DenisaCG added the enhancement New feature or request label May 22, 2024
@DenisaCG DenisaCG marked this pull request as draft May 22, 2024 15:39
@DenisaCG DenisaCG marked this pull request as ready for review May 23, 2024 16:55
@DenisaCG
Copy link
Member Author

Do you want to take a look and test it locally with your bucket before we merge it? Thanks! @trungleduc

@trungleduc
Copy link
Member

Thanks! I will take a look

@trungleduc
Copy link
Member

it works great! Thanks @DenisaCG

@DenisaCG
Copy link
Member Author

Great, thanks for testing it! @trungleduc

@DenisaCG DenisaCG merged commit a993b7c into QuantStack:main May 24, 2024
6 checks passed
@DenisaCG DenisaCG deleted the refactorListing branch May 24, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants