-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Need to restart jupyter server frequently #74
Comments
I think this is caused by session token being generated when the jupyter server starts and that it never gets refreshed. Reference: https://github.com/QuantStack/jupyter-drives/blob/main/jupyter_drives/base.py#L76 |
For extensions that have a server component like this, a single server restart is required. Are you saying that additional server restarts are needed? |
This requires additional server restart, if the app has been running for a long time the auth session times out but the S3Driver still holds the outdated auth session. I observed 500 error response and the UI is empty, user can't even tell whats happening, I created the issue #75 for the UX part of it: Error
Screenshot |
As a solution, at the very least we should try to reload the S3Driver credentials (https://github.com/QuantStack/jupyter-drives/blob/main/jupyter_drives/base.py#L76) if we receive this specific error in the server. Right now we are only doing it once during the initialization. |
Tested in SageMaker JupyterLab
Installed the extension, and kept the tab open. After some time (most likely after some kind of session timeout) S3 browser stopped showing S3 contents. Restarting jupyter server fixes the issue, but this should not be necessary
Expected
No need to restart jupyter server
The text was updated successfully, but these errors were encountered: