Unify API for updating entities

blazekv · blazekv · commit 5209974809fb · 2019-06-12T15:58:06.000+02:00
diff --git a/src/MailQ/Resources/NotificationResource.php b/src/MailQ/Resources/NotificationResource.php
@@ -29,13 +29,11 @@ public function createNotification(NotificationEntity $notification)
 	}
 
 	/**
-	 *
 	 * @param NotificationEntity $notification
-	 * @param int $notificationId
 	 */
-	public function updateNotification(NotificationEntity $notification, $notificationId)
+	public function updateNotification(NotificationEntity $notification)
 	{
-		$request = Request::put("{$this->getCompanyId()}/notifications/{$notificationId}");
+		$request = Request::put("{$this->getCompanyId()}/notifications/{$notification->getId()}");
 		$request->setContentAsEntity($notification);
 		$this->getConnector()->sendRequest($request);
 	}

Original file line number	Diff line number	Diff line change
`@@ -29,13 +29,11 @@ public function createNotification(NotificationEntity $notification)`
`29`	`29`	`}`
`30`	`30`
`31`	`31`	`/**`
`32`		`- *`
`33`	`32`	`* @param NotificationEntity $notification`
`34`		`- * @param int $notificationId`
`35`	`33`	`*/`
`36`		`- public function updateNotification(NotificationEntity $notification, $notificationId)`
	`34`	`+ public function updateNotification(NotificationEntity $notification)`
`37`	`35`	`{`
`38`		`- $request = Request::put("{$this->getCompanyId()}/notifications/{$notificationId}");`
	`36`	`+ $request = Request::put("{$this->getCompanyId()}/notifications/{$notification->getId()}");`
`39`	`37`	`$request->setContentAsEntity($notification);`
`40`	`38`	`$this->getConnector()->sendRequest($request);`
`41`	`39`	`}`