Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow custom install/log/config path #1256

Open
shrik3 opened this issue May 17, 2024 · 2 comments
Open

allow custom install/log/config path #1256

shrik3 opened this issue May 17, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@shrik3
Copy link
Collaborator

shrik3 commented May 17, 2024

currently the paths to qkernel binary, log files and config files are hardcoded, among others:

pub const LOG_FILE_DEFAULT: &str = "/var/log/quark/quark.log";
pub const RAWLOG_FILE_DEFAULT: &str = "/var/log/quark/raw.log";
pub const LOG_FILE_FORMAT: &str = "/var/log/quark/{}.log";
pub const KERNEL_IMAGE: &'static str = "/usr/local/bin/qkernel_d.bin";
pub const KERNEL_IMAGE: &'static str = "/usr/local/bin/qkernel.bin";
pub const VDSO_PATH: &'static str = "/usr/local/bin/vdso.so";

to do this, we can pass install/log/config path as env variables and build the above path strings during compile time using rust's env! macro.

@shrik3 shrik3 self-assigned this May 17, 2024
@shrik3 shrik3 added the enhancement New feature or request label May 22, 2024
@shrik3 shrik3 changed the title improvement: allow custom install/log/config path allow custom install/log/config path May 22, 2024
@shrik3
Copy link
Collaborator Author

shrik3 commented May 22, 2024

The binary installation paths are fine, but the log path is tricky. The log path /var/log/quark/* is hardcoded everywhere, also in subprojects like qservice, qserverless ... etc.

This would be low priority then.

@shrik3
Copy link
Collaborator Author

shrik3 commented May 23, 2024

This is necessary to build Quark packages for linux distributions, as they may not install binaries to the same path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant