Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow users to restore backup of qubes with custom labels on new systems #9781

Open
alimirjamali opened this issue Feb 17, 2025 · 0 comments · May be fixed by QubesOS/qubes-core-admin-client#335
Open

Allow users to restore backup of qubes with custom labels on new systems #9781

alimirjamali opened this issue Feb 17, 2025 · 0 comments · May be fixed by QubesOS/qubes-core-admin-client#335
Assignees
@alimirjamali
Labels
affects-4.2 This issue affects Qubes OS 4.2. C: core diagnosed Technical diagnosis has been performed (see issue comments). P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. pr submitted A pull request has been submitted for this issue.

Comments

@alimirjamali
Copy link

Qubes OS release

Qubes OS 4.2

Brief summary

If we allow/provide users with tools and/or API to create custom labels and they backup qubes with such labels, the restore operation would fail for such qubes on new systems without those custom labels.

Steps to reproduce

  1. Create custom label with admin.label.Create API call.
  2. Set a qube label to this new custom label
  3. Backup that qube
  4. Try to restore it

Expected behavior

Restore operation could revert to an existing label and allow user to access their backup

Actual behavior

Restore operation for qubes with custom label fails with vague error

Additional information

No response
@alimirjamali alimirjamali added the P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. label Feb 17, 2025
alimirjamali added a commit to alimirjamali/qubes-core-admin-client that referenced this issue Feb 17, 2025
@alimirjamali
Revert to red label while restoring on missing labels
32f6004 
If we allow users to create custom labels and they backup such qubes,
restore operation will fail on new systems without those custom labels.
Fix this by reverting to red label and allow users to restore their
backup.

fixes: QubesOS/qubes-issues#9781
@alimirjamali alimirjamali linked a pull request Feb 17, 2025 that will close this issue
Open
@andrewdavidwong andrewdavidwong added C: core diagnosed Technical diagnosis has been performed (see issue comments). pr submitted A pull request has been submitted for this issue. affects-4.2 This issue affects Qubes OS 4.2. labels Feb 17, 2025
alimirjamali added a commit to alimirjamali/qubes-core-admin-client that referenced this issue Feb 17, 2025
@alimirjamali
Revert to red label while restoring on missing labels
a04f8f7 
If we allow users to create custom labels and they backup such qubes,
restore operation will fail on new systems without those custom labels.
Fix this by reverting to red label and allow users to restore their
backup.

fixes: QubesOS/qubes-issues#9781
alimirjamali added a commit to alimirjamali/qubes-core-admin-client that referenced this issue Feb 17, 2025
@alimirjamali
Revert to red label while restoring on missing labels
8d771e3 
If we allow users to create custom labels and they backup such qubes,
restore operation will fail on new systems without those custom labels.
Fix this by reverting to red label and allow users to restore their
backup.

fixes: QubesOS/qubes-issues#9781
alimirjamali added a commit to alimirjamali/qubes-core-admin-client that referenced this issue Feb 17, 2025
@alimirjamali
Revert to red label while restoring on missing labels
5e0974e 
If we allow users to create custom labels and they backup such qubes,
restore operation will fail on new systems without those custom labels.
Fix this by reverting to red label and allow users to restore their
backup.

fixes: QubesOS/qubes-issues#9781
alimirjamali added a commit to alimirjamali/qubes-core-admin-client that referenced this issue Feb 17, 2025
@alimirjamali
Revert to red label while restoring on missing labels
88354e1 
If we allow users to create custom labels and they backup such qubes,
restore operation will fail on new systems without those custom labels.
Fix this by reverting to red label and allow users to restore their
backup.

fixes: QubesOS/qubes-issues#9781
alimirjamali added a commit to alimirjamali/qubes-core-admin-client that referenced this issue Feb 22, 2025
@alimirjamali
Revert to red label while restoring on missing labels
bb50a9a 
If we allow users to create custom labels and they backup such qubes,
restore operation will fail on new systems without those custom labels.
Fix this by reverting to red label and allow users to restore their
backup.

fixes: QubesOS/qubes-issues#9781
alimirjamali added a commit to alimirjamali/qubes-core-admin-client that referenced this issue Feb 22, 2025
@alimirjamali
Revert to red label while restoring on missing labels
1913e2b 
If we allow users to create custom labels and they backup such qubes,
restore operation will fail on new systems without those custom labels.
Fix this by reverting to red label and allow users to restore their
backup.

fixes: QubesOS/qubes-issues#9781
alimirjamali added a commit to alimirjamali/qubes-core-admin-client that referenced this issue Feb 22, 2025
@alimirjamali
Revert to red label while restoring on missing labels
d2a242a 
If we allow users to create custom labels and they backup such qubes,
restore operation will fail on new systems without those custom labels.
Fix this by reverting to red label and allow users to restore their
backup.

fixes: QubesOS/qubes-issues#9781
alimirjamali added a commit to alimirjamali/qubes-core-admin-client that referenced this issue Feb 23, 2025
@alimirjamali
Revert to red label while restoring on missing labels
3b469a8 
If we allow users to create custom labels and they backup such qubes,
restore operation will fail on new systems without those custom labels.
Fix this by reverting to red label and allow users to restore their
backup.

fixes: QubesOS/qubes-issues#9781
alimirjamali added a commit to alimirjamali/qubes-core-admin-client that referenced this issue Feb 23, 2025
@alimirjamali
Revert to red label while restoring on missing labels
5f4fbaf 
If we allow users to create custom labels and they backup such qubes,
restore operation will fail on new systems without those custom labels.
Fix this by reverting to red label and allow users to restore their
backup.

fixes: QubesOS/qubes-issues#9781
alimirjamali added a commit to alimirjamali/qubes-core-admin-client that referenced this issue Feb 23, 2025
@alimirjamali
Revert to red label while restoring on missing labels
ddf9898 
If we allow users to create custom labels and they backup such qubes,
restore operation will fail on new systems without those custom labels.
Fix this by reverting to red label and allow users to restore their
backup.

fixes: QubesOS/qubes-issues#9781
alimirjamali added a commit to alimirjamali/qubes-core-admin-client that referenced this issue Feb 23, 2025
@alimirjamali
Revert to red label while restoring on missing labels
41ddf2f 
If we allow users to create custom labels and they backup such qubes,
restore operation will fail on new systems without those custom labels.
Fix this by reverting to red label and allow users to restore their
backup.

fixes: QubesOS/qubes-issues#9781
alimirjamali added a commit to alimirjamali/qubes-core-admin-client that referenced this issue Feb 23, 2025
@alimirjamali
Revert to red label while restoring on missing labels
a116092 
If we allow users to create custom labels and they backup such qubes,
restore operation will fail on new systems without those custom labels.
Fix this by reverting to red label and allow users to restore their
backup.

fixes: QubesOS/qubes-issues#9781
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alimirjamali alimirjamali

Labels
affects-4.2 This issue affects Qubes OS 4.2. C: core diagnosed Technical diagnosis has been performed (see issue comments). P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. pr submitted A pull request has been submitted for this issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Revert to red label while restoring on missing labels alimirjamali/qubes-core-admin-client
2 participants
@alimirjamali @andrewdavidwong