Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable systemd-nsresourced and systemd-userdbd for minimal sys-net and minimal sys-usb #554

Merged
merged 1 commit into from
Feb 24, 2025

Conversation

Guiiix
Copy link
Member

@Guiiix Guiiix commented Feb 23, 2025

This disables two more services for minimal sys-net and minimal sys-usb (see #540) :

  • systemd-nsresourced.service and its socket systemd-nsresourced.socket
  • systemd-userdbd.service and its socket systemd-userdbd.socket

Copy link

codecov bot commented Feb 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.57%. Comparing base (a5ae111) to head (5a3e3ae).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #554   +/-   ##
=======================================
  Coverage   70.57%   70.57%           
=======================================
  Files           3        3           
  Lines         469      469           
=======================================
  Hits          331      331           
  Misses        138      138           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@qubesos-bot
Copy link

OpenQA test summary

Complete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025022318-4.3&flavor=pull-requests

Test run included the following:

New failures, excluding unstable

Compared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025021804-4.3&flavor=update

  • system_tests_qrexec

  • system_tests_backupdispvm

    • TC_10_RestoreInDispVM_debian-12-xfce: test_000_basic_backup (failure)
      test-inst-testhvm1 | StandaloneVM | n/a | ...

    • TC_10_RestoreInDispVM_fedora-41-xfce: test_000_basic_backup (failure)
      test-inst-testhvm1 | StandaloneVM | n/a | ...

    • TC_10_RestoreInDispVM_whonix-gateway-17: test_000_basic_backup (failure)
      test-inst-testhvm1 | StandaloneVM | n/a | ...

    • TC_10_RestoreInDispVM_whonix-workstation-17: test_000_basic_backup (failure)
      test-inst-testhvm1 | StandaloneVM | n/a | ...

  • system_tests_kde_gui_interactive

    • gui_keyboard_layout: wait_serial (wait serial expected)
      # wait_serial expected: "echo -e '[Layout]\nLayoutList=us,de' | sud...

    • gui_keyboard_layout: Failed (test died)
      # Test died: command 'test "$(cd ~user;ls e1*)" = "$(qvm-run -p wor...

  • system_tests_audio@hw1

Failed tests

10 failures
  • system_tests_qrexec

  • system_tests_backupdispvm

    • TC_10_RestoreInDispVM_debian-12-xfce: test_000_basic_backup (failure)
      test-inst-testhvm1 | StandaloneVM | n/a | ...

    • TC_10_RestoreInDispVM_fedora-41-xfce: test_000_basic_backup (failure)
      test-inst-testhvm1 | StandaloneVM | n/a | ...

    • TC_10_RestoreInDispVM_whonix-gateway-17: test_000_basic_backup (failure)
      test-inst-testhvm1 | StandaloneVM | n/a | ...

    • TC_10_RestoreInDispVM_whonix-workstation-17: test_000_basic_backup (failure)
      test-inst-testhvm1 | StandaloneVM | n/a | ...

  • system_tests_kde_gui_interactive

    • gui_keyboard_layout: wait_serial (wait serial expected)
      # wait_serial expected: "echo -e '[Layout]\nLayoutList=us,de' | sud...

    • gui_keyboard_layout: Failed (test died)
      # Test died: command 'test "$(cd ~user;ls e1*)" = "$(qvm-run -p wor...

  • system_tests_audio@hw1

Fixed failures

Compared to: https://openqa.qubes-os.org/tests/129058#dependencies

14 fixed
  • system_tests_suspend

    • suspend: unnamed test (unknown)
    • suspend: Failed (test died)
      # Test died: no candidate needle with tag(s) 'SUSPEND-FAILED' match...
  • system_tests_kde_gui_interactive

    • clipboard_and_web: unnamed test (unknown)
    • clipboard_and_web: Failed (test died)
      # Test died: no candidate needle with tag(s) 'clipboard-paste-notif...
  • system_tests_audio

  • system_tests_whonix@hw7

    • whonixcheck: fail (unknown)
      Whonixcheck for sys-whonix failed...

    • whonixcheck: unnamed test (unknown)

  • system_tests_basic_vm_qrexec_gui_btrfs

    • TC_03_QvmRevertTemplateChanges: test_000_revert_linux (error)
      subprocess.CalledProcessError: Command '['sha1sum', '/var/lib/qubes...
  • system_tests_whonix

    • whonixcheck: fail (unknown)
      Whonixcheck for sys-whonix failed...

    • whonixcheck: unnamed test (unknown)

  • system_tests_suspend@hw1

    • suspend: unnamed test (unknown)
    • suspend: Failed (test died)
      # Test died: no candidate needle with tag(s) 'SUSPEND-FAILED' match...

Unstable tests

Performance Tests

Performance degradation:

12 performance degradations
  • debian-12-xfce_exec: 8.20 :small_red_triangle_up: ( previous job: 7.15, degradation: 114.69%)
  • whonix-workstation-17_exec-data-simplex: 54.90 :small_red_triangle_up: ( previous job: 47.01, degradation: 116.76%)
  • dom0_root_seq1m_q8t1_write 3:write_bandwidth_kb: 166692.00 :small_red_triangle_up: ( previous job: 276742.00, degradation: 60.23%)
  • dom0_root_seq1m_q1t1_write 3:write_bandwidth_kb: 117069.00 :small_red_triangle_up: ( previous job: 185030.00, degradation: 63.27%)
  • dom0_root_rnd4k_q32t1_read 3:read_bandwidth_kb: 26818.00 :small_red_triangle_up: ( previous job: 100699.00, degradation: 26.63%)
  • dom0_varlibqubes_seq1m_q8t1_read 3:read_bandwidth_kb: 355690.00 :small_red_triangle_up: ( previous job: 475329.00, degradation: 74.83%)
  • dom0_varlibqubes_seq1m_q1t1_write 3:write_bandwidth_kb: 135021.00 :small_red_triangle_up: ( previous job: 164133.00, degradation: 82.26%)
  • dom0_varlibqubes_rnd4k_q32t1_write 3:write_bandwidth_kb: 6643.00 :small_red_triangle_up: ( previous job: 8767.00, degradation: 75.77%)
  • fedora-41-xfce_root_rnd4k_q32t1_write 3:write_bandwidth_kb: 969.00 :small_red_triangle_up: ( previous job: 3785.00, degradation: 25.60%)
  • fedora-41-xfce_root_rnd4k_q1t1_write 3:write_bandwidth_kb: 742.00 :small_red_triangle_up: ( previous job: 1126.00, degradation: 65.90%)
  • fedora-41-xfce_private_seq1m_q8t1_write 3:write_bandwidth_kb: 103703.00 :small_red_triangle_up: ( previous job: 116848.00, degradation: 88.75%)
  • fedora-41-xfce_private_rnd4k_q32t1_write 3:write_bandwidth_kb: 2687.00 :small_red_triangle_up: ( previous job: 3885.00, degradation: 69.16%)

Remaining performance tests:

60 tests
  • debian-12-xfce_exec-root: 28.16 :small_red_triangle_up: ( previous job: 27.97, degradation: 100.68%)
  • debian-12-xfce_socket: 8.66 :small_red_triangle_up: ( previous job: 8.33, degradation: 103.94%)
  • debian-12-xfce_socket-root: 8.03 🟢 ( previous job: 8.20, improvement: 97.93%)
  • debian-12-xfce_exec-data-simplex: 44.89 🟢 ( previous job: 48.93, improvement: 91.74%)
  • debian-12-xfce_exec-data-duplex: 46.83 🟢 ( previous job: 50.76, improvement: 92.25%)
  • debian-12-xfce_exec-data-duplex-root: 65.98 :small_red_triangle_up: ( previous job: 64.91, degradation: 101.65%)
  • debian-12-xfce_socket-data-duplex: 79.40 🟢 ( previous job: 81.49, improvement: 97.43%)
  • fedora-41-xfce_exec: 9.09 🟢 ( previous job: 9.13, improvement: 99.50%)
  • fedora-41-xfce_exec-root: 60.59 🟢 ( previous job: 61.17, improvement: 99.04%)
  • fedora-41-xfce_socket: 8.38 🟢 ( previous job: 8.66, improvement: 96.71%)
  • fedora-41-xfce_socket-root: 8.44 🟢 ( previous job: 8.61, improvement: 98.07%)
  • fedora-41-xfce_exec-data-simplex: 48.72 🟢 ( previous job: 49.65, improvement: 98.13%)
  • fedora-41-xfce_exec-data-duplex: 47.96 🟢 ( previous job: 49.08, improvement: 97.71%)
  • fedora-41-xfce_exec-data-duplex-root: 81.62 🟢 ( previous job: 81.65, improvement: 99.96%)
  • fedora-41-xfce_socket-data-duplex: 77.11 🟢 ( previous job: 78.62, improvement: 98.08%)
  • whonix-gateway-17_exec: 6.83 🟢 ( previous job: 7.87, improvement: 86.86%)
  • whonix-gateway-17_exec-root: 38.08 🟢 ( previous job: 38.36, improvement: 99.25%)
  • whonix-gateway-17_socket: 7.70 :small_red_triangle_up: ( previous job: 7.54, degradation: 102.11%)
  • whonix-gateway-17_socket-root: 7.75 🟢 ( previous job: 8.27, improvement: 93.66%)
  • whonix-gateway-17_exec-data-simplex: 48.21 🟢 ( previous job: 48.76, improvement: 98.87%)
  • whonix-gateway-17_exec-data-duplex: 46.95 🟢 ( previous job: 48.55, improvement: 96.69%)
  • whonix-gateway-17_exec-data-duplex-root: 72.28 :small_red_triangle_up: ( previous job: 70.13, degradation: 103.07%)
  • whonix-gateway-17_socket-data-duplex: 86.03 :small_red_triangle_up: ( previous job: 82.74, degradation: 103.98%)
  • whonix-workstation-17_exec: 8.22 🟢 ( previous job: 8.23, improvement: 99.87%)
  • whonix-workstation-17_exec-root: 52.10 🟢 ( previous job: 52.56, improvement: 99.12%)
  • whonix-workstation-17_socket: 8.13 🟢 ( previous job: 8.21, improvement: 99.03%)
  • whonix-workstation-17_socket-root: 8.04 🟢 ( previous job: 8.20, improvement: 98.04%)
  • whonix-workstation-17_exec-data-duplex: 49.48 :small_red_triangle_up: ( previous job: 49.48, degradation: 100.01%)
  • whonix-workstation-17_exec-data-duplex-root: 80.16 :small_red_triangle_up: ( previous job: 79.93, degradation: 100.29%)
  • whonix-workstation-17_socket-data-duplex: 84.82 :small_red_triangle_up: ( previous job: 81.71, degradation: 103.81%)
  • dom0_root_seq1m_q8t1_read 3:read_bandwidth_kb: 485901.00 :small_red_triangle_up: ( previous job: 486352.00, degradation: 99.91%)
  • dom0_root_seq1m_q1t1_read 3:read_bandwidth_kb: 426423.00 :green_circle: ( previous job: 423495.00, improvement: 100.69%)
  • dom0_root_rnd4k_q32t1_write 3:write_bandwidth_kb: 4082.00 :green_circle: ( previous job: 3277.00, improvement: 124.57%)
  • dom0_root_rnd4k_q1t1_read 3:read_bandwidth_kb: 10019.00 :small_red_triangle_up: ( previous job: 10163.00, degradation: 98.58%)
  • dom0_root_rnd4k_q1t1_write 3:write_bandwidth_kb: 4285.00 :green_circle: ( previous job: 282.00, improvement: 1519.50%)
  • dom0_varlibqubes_seq1m_q8t1_write 3:write_bandwidth_kb: 269349.00 :green_circle: ( previous job: 95209.00, improvement: 282.90%)
  • dom0_varlibqubes_seq1m_q1t1_read 3:read_bandwidth_kb: 428865.00 :small_red_triangle_up: ( previous job: 433474.00, degradation: 98.94%)
  • dom0_varlibqubes_rnd4k_q32t1_read 3:read_bandwidth_kb: 101053.00 :green_circle: ( previous job: 99808.00, improvement: 101.25%)
  • dom0_varlibqubes_rnd4k_q1t1_read 3:read_bandwidth_kb: 8320.00 :green_circle: ( previous job: 7053.00, improvement: 117.96%)
  • dom0_varlibqubes_rnd4k_q1t1_write 3:write_bandwidth_kb: 4655.00 :green_circle: ( previous job: 3868.00, improvement: 120.35%)
  • fedora-41-xfce_root_seq1m_q8t1_read 3:read_bandwidth_kb: 408960.00 :green_circle: ( previous job: 396586.00, improvement: 103.12%)
  • fedora-41-xfce_root_seq1m_q8t1_write 3:write_bandwidth_kb: 134683.00 :green_circle: ( previous job: 99783.00, improvement: 134.98%)
  • fedora-41-xfce_root_seq1m_q1t1_read 3:read_bandwidth_kb: 330468.00 :small_red_triangle_up: ( previous job: 343795.00, degradation: 96.12%)
  • fedora-41-xfce_root_seq1m_q1t1_write 3:write_bandwidth_kb: 66591.00 :green_circle: ( previous job: 44770.00, improvement: 148.74%)
  • fedora-41-xfce_root_rnd4k_q32t1_read 3:read_bandwidth_kb: 79655.00 :small_red_triangle_up: ( previous job: 86742.00, degradation: 91.83%)
  • fedora-41-xfce_root_rnd4k_q1t1_read 3:read_bandwidth_kb: 8652.00 :green_circle: ( previous job: 8623.00, improvement: 100.34%)
  • fedora-41-xfce_private_seq1m_q8t1_read 3:read_bandwidth_kb: 404075.00 :green_circle: ( previous job: 401907.00, improvement: 100.54%)
  • fedora-41-xfce_private_seq1m_q1t1_read 3:read_bandwidth_kb: 322242.00 :small_red_triangle_up: ( previous job: 357875.00, degradation: 90.04%)
  • fedora-41-xfce_private_seq1m_q1t1_write 3:write_bandwidth_kb: 79646.00 :green_circle: ( previous job: 41375.00, improvement: 192.50%)
  • fedora-41-xfce_private_rnd4k_q32t1_read 3:read_bandwidth_kb: 84788.00 :small_red_triangle_up: ( previous job: 87999.00, degradation: 96.35%)
  • fedora-41-xfce_private_rnd4k_q1t1_read 3:read_bandwidth_kb: 9126.00 :green_circle: ( previous job: 8744.00, improvement: 104.37%)
  • fedora-41-xfce_private_rnd4k_q1t1_write 3:write_bandwidth_kb: 1813.00 :green_circle: ( previous job: 1613.00, improvement: 112.40%)
  • fedora-41-xfce_volatile_seq1m_q8t1_read 3:read_bandwidth_kb: 424696.00 :green_circle: ( previous job: 392725.00, improvement: 108.14%)
  • fedora-41-xfce_volatile_seq1m_q8t1_write 3:write_bandwidth_kb: 160643.00 :green_circle: ( previous job: 139933.00, improvement: 114.80%)
  • fedora-41-xfce_volatile_seq1m_q1t1_read 3:read_bandwidth_kb: 338906.00 :green_circle: ( previous job: 294875.00, improvement: 114.93%)
  • fedora-41-xfce_volatile_seq1m_q1t1_write 3:write_bandwidth_kb: 125725.00 :green_circle: ( previous job: 78093.00, improvement: 160.99%)
  • fedora-41-xfce_volatile_rnd4k_q32t1_read 3:read_bandwidth_kb: 85291.00 :green_circle: ( previous job: 71108.00, improvement: 119.95%)
  • fedora-41-xfce_volatile_rnd4k_q32t1_write 3:write_bandwidth_kb: 4071.00 :green_circle: ( previous job: 3959.00, improvement: 102.83%)
  • fedora-41-xfce_volatile_rnd4k_q1t1_read 3:read_bandwidth_kb: 8147.00 :small_red_triangle_up: ( previous job: 8408.00, degradation: 96.90%)
  • fedora-41-xfce_volatile_rnd4k_q1t1_write 3:write_bandwidth_kb: 2447.00 :small_red_triangle_up: ( previous job: 2693.00, degradation: 90.87%)

@marmarek marmarek merged commit 5a3e3ae into QubesOS:main Feb 24, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants