-
-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Retire old qubes-vm-create
dialog
#393
Conversation
Development notes: Adding |
be68559
to
14cc82d
Compare
As noted in the other issue, IMO better to simply remove the old create qube dialog (and replace its use with the new one). |
I'll pick just the dependency fix from here |
OK. But I think it is better to do it for 4.3 branch and not 4.2. I will make a separate PR for the above task, properly ditching the old one. So it could be easily merged to 4.3 branch. |
Well, "main" branch is "4.3 branch" :) |
14cc82d
to
c79cbf5
Compare
Create Qubes VM
to the xfce4-panel
menuqubes-vm-create
dialog
e4f6046
to
210f867
Compare
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2024112705-4.3&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025021804-4.3&flavor=update
Failed tests5 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/129058#dependencies 15 fixed
Unstable tests
Performance TestsPerformance degradation:No issues Remaining performance tests:No remaining performance tests |
Now that #400 is merged, this needs rebase... |
Retire the the old PyQt based `qubes-vm-create` dialog and replace it with GTK based `qubes-new-qube` for Qube Manager. resolves: QubesOS/qubes-issues#6561
210f867
to
04de057
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #393 +/- ##
==========================================
+ Coverage 65.82% 68.29% +2.46%
==========================================
Files 18 17 -1
Lines 3901 3715 -186
==========================================
- Hits 2568 2537 -31
+ Misses 1333 1178 -155 ☔ View full report in Codecov by Sentry. |
resolves: QubesOS/qubes-issues#6561