Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add 'count fallback' option for stats and add stat icon settings #255

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

ix0rai
Copy link
Member

@ix0rai ix0rai commented Feb 10, 2025

  • adds an option for counting fallback-proposed entries as mapped
  • refactors stats generation to add a GenerationParameters class that cleans up method signatures and avoids future breakage
  • adds options in the view menu for configuring the parameters of the stats used for stat icons
    • introduces UI for the 'disable icons' setting i added a while ago
    • instantly reloads when settings change
    • very slick
  • reworks the way config works for stats
    • what were previously the settings for the dialog now control the icons
    • config will now no longer be saved when changing settings in the dialog (besides the dialog-exclusive package filter)
    • dialog opens with the current icon settings

@ix0rai ix0rai added enhancement New feature or request backend affects the enigma backend user interface affects the enigma ui labels Feb 10, 2025
Copy link
Member Author

@ix0rai ix0rai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some mistakes i found, will clean this up soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend affects the enigma backend enhancement New feature or request user interface affects the enigma ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant