Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug in ClassProvider #258

Merged
merged 2 commits into from
Feb 25, 2025
Merged

Fix bug in ClassProvider #258

merged 2 commits into from
Feb 25, 2025

Conversation

PiTheGuy
Copy link
Contributor

Fixes #257

@ix0rai ix0rai added bug Something isn't working backend affects the enigma backend labels Feb 18, 2025
ix0rai
ix0rai approved these changes Feb 24, 2025
View reviewed changes
Copy link
Member

@ix0rai ix0rai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you so much for tracking down this bug! i would appreciate if you could make a unit test for it :)

ix0rai
ix0rai approved these changes Feb 25, 2025
View reviewed changes
Copy link
Member

@ix0rai ix0rai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unit test looks great!

@ix0rai ix0rai merged commit a012637 into QuiltMC:master Feb 25, 2025
2 checks passed
@PiTheGuy PiTheGuy deleted the class-provider-fix branch February 25, 2025 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ix0rai ix0rai ix0rai approved these changes

Assignees
No one assigned
Labels
backend affects the enigma backend bug Something isn't working
Projects
None yet
Milestone
No milestone
2 participants
@PiTheGuy @ix0rai