fix(core): canSerialize self-references

Author: wmertens

packages/qwik/src/core/shared/shared-serialization.ts

@@ -1523,7 +1523,7 @@ const frameworkType = (obj: any) => {
   );
 };
 
-export const canSerialize = (value: any): boolean => {
+export const canSerialize = (value: any, seen: WeakSet<any> = new WeakSet()): boolean => {
   if (
     value == null ||
     typeof value === 'string' ||
@@ -1533,6 +1533,10 @@ export const canSerialize = (value: any): boolean => {
   ) {
     return true;
   } else if (typeof value === 'object') {
+    if (seen.has(value)) {
+      return true;
+    }
+    seen.add(value);
     const proto = Object.getPrototypeOf(value);
     if (isStore(value)) {
       value = getStoreTarget(value);
@@ -1541,14 +1545,19 @@ export const canSerialize = (value: any): boolean => {
       for (const key in value) {
         // if the value is a props proxy, then sometimes we could create a component-level subscription,
         // so we should call untrack here to avoid tracking the value
-        if (!canSerialize(untrack(() => value[key]))) {
+        if (
+          !canSerialize(
+            untrack(() => value[key]),
+            seen
+          )
+        ) {
           return false;
         }
       }
       return true;
     } else if (proto == Array.prototype) {
       for (let i = 0; i < value.length; i++) {
-        if (!canSerialize(value[i])) {
+        if (!canSerialize(value[i], seen)) {
           return false;
         }
       }

packages/qwik/src/core/shared/utils/serialize-utils.ts

@@ -8,20 +8,27 @@ import { unwrapStore } from '../../signal/store';
 
 /** @internal */
 export const verifySerializable = <T>(value: T, preMessage?: string): T => {
-  const seen = new Set();
+  const seen = new WeakSet();
   return _verifySerializable(value, seen, '_', preMessage);
 };
 
-const _verifySerializable = <T>(value: T, seen: Set<any>, ctx: string, preMessage?: string): T => {
+const _verifySerializable = <T>(
+  value: T,
+  seen: WeakSet<any>,
+  ctx: string,
+  preMessage?: string
+): T => {
   const unwrapped = unwrapStore(value);
   if (unwrapped == null) {
     return value;
   }
   if (shouldSerialize(unwrapped)) {
-    if (seen.has(unwrapped)) {
-      return value;
+    if (typeof unwrapped === 'object') {
+      if (seen.has(unwrapped)) {
+        return value;
+      }
+      seen.add(unwrapped);
     }
-    seen.add(unwrapped);
     if (isSignal(unwrapped)) {
       return value;
     }