chore(core signals): cleanup

Author: wmertens

packages/qwik/src/core/signal/signal-api.ts

@@ -2,11 +2,13 @@ import type { QRLInternal } from '../shared/qrl/qrl-class';
 import type { QRL } from '../shared/qrl/qrl.public';
 import { ComputedSignal, Signal, throwIfQRLNotResolved } from './signal';
 
+/** @internal */
 export const createSignal = <T>(value?: T) => {
   return new Signal(null, value);
 };
 
+/** @internal */
 export const createComputedSignal = <T>(qrl: QRL<() => T>) => {
   throwIfQRLNotResolved(qrl);
-  return new ComputedSignal(null, qrl as QRLInternal<() => T>);
+  return new ComputedSignal<T>(null, qrl as QRLInternal<() => T>);
 };

packages/qwik/src/core/signal/signal.ts

@@ -47,7 +47,7 @@ export interface InternalSignal<T = any> extends InternalReadonlySignal<T> {
   untrackedValue: T;
 }
 
-export const throwIfQRLNotResolved = <T>(qrl: QRL<() => T>) => {
+export const throwIfQRLNotResolved = (qrl: QRL) => {
   const resolved = qrl.resolved;
   if (!resolved) {
     // When we are creating a signal using a use method, we need to ensure
@@ -205,7 +205,6 @@ export class Signal<T = any> implements ISignal<T> {
     }
     return this.untrackedValue;
   }
-
   set value(value) {
     if (value !== this.$untrackedValue$) {
       DEBUG &&
@@ -374,6 +373,8 @@ export const triggerEffects = (
   DEBUG && log('done scheduling');
 };
 
+type ComputeQRL<T> = QRLInternal<(prev: T | undefined) => T>;
+
 /**
  * A signal which is computed from other signals.
  *
@@ -386,13 +387,13 @@ export class ComputedSignal<T> extends Signal<T> {
    * The computed functions must be executed synchronously (because of this we need to eagerly
    * resolve the QRL during the mark dirty phase so that any call to it will be synchronous). )
    */
-  $computeQrl$: QRLInternal<() => T>;
+  $computeQrl$: ComputeQRL<T>;
   // We need a separate flag to know when the computation needs running because
   // we need the old value to know if effects need running after computation
   $invalid$: boolean = true;
   $forceRunEffects$: boolean = false;
 
-  constructor(container: Container | null, fn: QRLInternal<() => T>) {
+  constructor(container: Container | null, fn: ComputeQRL<T>) {
     // The value is used for comparison when signals trigger, which can only happen
     // when it was calculated before. Therefore we can pass whatever we like.
     super(container, NEEDS_COMPUTATION);
@@ -459,14 +460,14 @@ export class ComputedSignal<T> extends Signal<T> {
     }
   }
 
-  // Getters don't get inherited
-  get value() {
-    return super.value;
-  }
-
+  // Make this signal read-only
   set value(_: any) {
     throw qError(QError.computedReadOnly);
   }
+  // Getters don't get inherited when overriding a setter
+  get value() {
+    return super.value;
+  }
 }
 
 export class WrappedSignal<T> extends Signal<T> implements Subscriber {
@@ -540,13 +541,12 @@ export class WrappedSignal<T> extends Signal<T> implements Subscriber {
     }
     return didChange;
   }
-
-  // Getters don't get inherited
-  get value() {
-    return super.value;
-  }
-
+  // Make this signal read-only
   set value(_: any) {
     throw qError(QError.wrappedReadOnly);
   }
+  // Getters don't get inherited when overriding a setter
+  get value() {
+    return super.value;
+  }
 }