wip failing component rerender after signal

Author: wmertens

packages/qwik/src/core/shared/scheduler.ts

@@ -113,7 +113,7 @@ import { serializeAttribute } from './utils/styles';
 import type { ValueOrPromise } from './utils/types';
 
 // Turn this on to get debug output of what the scheduler is doing.
-const DEBUG: boolean = false;
+const DEBUG: boolean = true;
 
 export const enum ChoreType {
   /// MASKS defining three levels of sorting
@@ -259,6 +259,13 @@ export const createScheduler = (
       type === ChoreType.NODE_DIFF ||
       type === ChoreType.NODE_PROP;
     if (isServer && isClientOnly) {
+      DEBUG &&
+        debugTrace(
+          `skip client chore ${debugChoreTypeToString(type)}`,
+          null,
+          currentChore,
+          choreQueue
+        );
       return;
     }
 
@@ -675,8 +682,8 @@ function vNodeAlreadyDeleted(chore: Chore): boolean {
   );
 }
 
-function debugChoreToString(chore: Chore): string {
-  const type =
+function debugChoreTypeToString(type: ChoreType): string {
+  return (
     (
       {
         [ChoreType.QRL_RESOLVE]: 'QRL_RESOLVE',
@@ -691,8 +698,12 @@ function debugChoreToString(chore: Chore): string {
         [ChoreType.VISIBLE]: 'VISIBLE',
         [ChoreType.CLEANUP_VISIBLE]: 'CLEANUP_VISIBLE',
         [ChoreType.WAIT_FOR_ALL]: 'WAIT_FOR_ALL',
-      } as any
-    )[chore.$type$] || 'UNKNOWN: ' + chore.$type$;
+      } as Record<ChoreType, string>
+    )[type] || 'UNKNOWN: ' + type
+  );
+}
+function debugChoreToString(chore: Chore): string {
+  const type = debugChoreTypeToString(chore.$type$);
   const host = String(chore.$host$).replaceAll(/\n.*/gim, '');
   const qrlTarget = (chore.$target$ as QRLInternal<any>)?.$symbol$;
   return `Chore(${type} ${chore.$type$ === ChoreType.QRL_RESOLVE || chore.$type$ === ChoreType.RUN_QRL ? qrlTarget : host} ${chore.$idx$})`;

packages/qwik/src/core/tests/use-task.spec.tsx

@@ -14,12 +14,12 @@ import { ErrorProvider } from '../../testing/rendering.unit-util';
 import { delay } from '../shared/utils/promises';
 import { WrappedSignal } from '../signal/signal';
 
-const debug = false; //true;
+const debug = !false; //true;
 Error.stackTraceLimit = 100;
 
 describe.each([
   { render: ssrRenderToDom }, //
-  { render: domRender }, //
+  // { render: domRender }, //
 ])('$render.name: useTask', ({ render }) => {
   it('should execute task', async () => {
     const Counter = component$(() => {
@@ -759,4 +759,27 @@ describe.each([
       );
     });
   });
+  it.only('should rerender component after task', async ({}) => {
+    const Cmp = component$(() => {
+      const sort = useSignal<'id' | 'size'>('size');
+      const table = useSignal([
+        { id: 1, size: 4 },
+        { id: 2, size: 3 },
+        { id: 3, size: 2 },
+        { id: 4, size: 1 },
+        { id: 5, size: 7 },
+        { id: 6, size: 8 },
+        { id: 7, size: 9 },
+      ]);
+
+      useTask$(({ track }) => {
+        track(() => sort.value);
+        table.value = table.value.sort((a, b) => a[sort.value] - b[sort.value]).slice();
+      });
+
+      return table.value.map((row) => row.size).join(' ');
+    });
+    const { vNode } = await render(<Cmp />, { debug });
+    expect(vNode).toMatchVDOM(<Component>1 2 3 4 7 8 9</Component>);
+  });
 });