fix(plugin): generate correct keys in q-manifest.json

the keys are the paths to the js bundles, and using hard-coded names like for entries gave the old names.

Author: wmertens

packages/qwik/src/optimizer/src/manifest.ts

@@ -257,13 +257,17 @@ export function generateManifestFromBundles(
     },
   };
 
+  const buildPath = path.resolve(opts.rootDir, opts.outDir, 'build');
   // We need to find our QRL exports
   const qrlNames = new Set([...hooks.map((h) => h.name)]);
-  for (const [fileName, outputBundle] of Object.entries(outputBundles)) {
+  for (const outputBundle of Object.values(outputBundles)) {
     if (outputBundle.type !== 'chunk') {
       continue;
     }
-    const bundleFileName = path.basename(fileName);
+    const bundleFileName = path.relative(
+      buildPath,
+      path.resolve(opts.outDir, outputBundle.fileName)
+    );
 
     const buildDirName = path.dirname(outputBundle.fileName);
     const bundle: QwikBundle = {
@@ -282,21 +286,23 @@ export function generateManifestFromBundles(
 
     const bundleImports = outputBundle.imports
       .filter((i) => path.dirname(i) === buildDirName)
-      .map((i) => path.relative(buildDirName, i));
+      .map((i) => path.relative(buildDirName, outputBundles[i].fileName));
     if (bundleImports.length > 0) {
       bundle.imports = bundleImports;
     }
 
     const bundleDynamicImports = outputBundle.dynamicImports
       .filter((i) => path.dirname(i) === buildDirName)
-      .map((i) => path.relative(buildDirName, i));
+      .map((i) => path.relative(buildDirName, outputBundles[i].fileName));
     if (bundleDynamicImports.length > 0) {
       bundle.dynamicImports = bundleDynamicImports;
     }
 
     // Rollup doesn't provide the moduleIds in the outputBundle but Vite does
     const ids = outputBundle.moduleIds || Object.keys(outputBundle.modules);
-    const modulePaths = ids.filter((m) => !m.startsWith(`\u0000`));
+    const modulePaths = ids
+      .filter((m) => !m.startsWith(`\u0000`))
+      .map((m) => path.relative(opts.rootDir, m));
     if (modulePaths.length > 0) {
       bundle.origins = modulePaths;
     }
@@ -324,6 +330,30 @@ export function generateManifestFromBundles(
       loc: hook.loc,
     };
   }
+  // To inspect the bundles, uncomment the following lines
+  // and temporarily add the writeFileSync import from fs
+  // writeFileSync(
+  //   'output-bundles.json',
+  //   JSON.stringify(
+  //     Object.entries(outputBundles).map(([n, b]) => [
+  //       n,
+  //       {
+  //         ...b,
+  //         code: '<removed>',
+  //         map: '<removed>',
+  //         source: '<removed>',
+  //         modules:
+  //           'modules' in b
+  //             ? Object.fromEntries(
+  //                 Object.entries(b.modules).map(([k, v]) => [k, { ...v, code: '<removed>' }])
+  //               )
+  //             : undefined,
+  //       },
+  //     ]),
+  //     null,
+  //     '\t'
+  //   )
+  // );
 
   return updateSortAndPriorities(manifest);
 }