Skip to content

Commit 272e847

Browse files
authored
Merge pull request #230 from R-ArcGIS/no-verify
Support querying layers that do not explicitly show query capabilities
2 parents 896ac00 + 2fd6d01 commit 272e847

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

Diff for: NEWS.md

+2
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,13 @@
11
# arcgislayers (development version)
22

3+
34
## New features
45

56
- Improve handling of `filter_geom` by `arc_select()` by warning if applying `sf::st_union()` to the filter does not generate a length 1 sfc, or if `filter_geom` is supplied when accessing a Table, or if `filter_geom` is empty (@elipousson, #166)
67

78
## Bug fixes
89

10+
- Adjusts `arc_select()` to not error out when `query` capability isn't explicitly listed. Instead `cli_alert_danger()` is used to communicate the issue <https://github.com/R-ArcGIS/arcgislayers/pull/230>
911
- `arc_select()` includes argument name in error message when `...` contains non-string values. <https://github.com/R-ArcGIS/arcgislayers/issues/226>
1012

1113
## Breaking changes

Diff for: R/arc-select.R

+2-2
Original file line numberDiff line numberDiff line change
@@ -189,9 +189,9 @@ collect_layer <- function(
189189
FALSE
190190
)
191191

192-
# throw error if the layer cannot query
192+
# throw warning if the layer cannot query
193193
if (!can_query) {
194-
cli::cli_abort(
194+
cli::cli_alert_danger(
195195
"{class(x)} {.val {x[['name']]}} does not support querying",
196196
call = error_call
197197
)

0 commit comments

Comments
 (0)