Skip to content

Commit fadc050

Browse files
authored
Merge pull request #227 from elipousson/fix-dots-error-message
Improve `arc_select()` error message per #226
2 parents 68b3d45 + c771306 commit fadc050

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

Diff for: NEWS.md

+4
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,10 @@
44

55
- `dplyr` methods for `collect()`, `select()`, and `filter()` have been removed. <https://github.com/R-ArcGIS/arcgislayers/issues/111> <https://github.com/R-ArcGIS/arcgislayers/issues/224> <https://github.com/R-ArcGIS/arcgislayers/issues/218>
66

7+
## Bug fixes
8+
9+
- `arc_select()` includes argument name in error message when `...` contains non-string values. <https://github.com/R-ArcGIS/arcgislayers/issues/226>
10+
711
# arcgislayers 0.3.1
812

913
## Bug fixes

Diff for: R/arc-select.R

+1-1
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ arc_select <- function(
101101
key <- dots_names[i]
102102
val <- dots[[i]]
103103
# check that the value is a scalar and non-empty
104-
check_string(val, allow_empty = FALSE)
104+
check_string(val, arg = key, allow_empty = FALSE)
105105

106106
# insert into query
107107
query[[key]] <- val

0 commit comments

Comments
 (0)