move GPIO_InitStruct variable inside to PIN_IRQ_ENABLE. thanks to @mysterywolf

diamant3 · Rbb666 · commit 5010c175396d · 2024-10-12T22:34:42.000+08:00
diff --git a/bsp/stm32/libraries/HAL_Drivers/drivers/drv_gpio.c b/bsp/stm32/libraries/HAL_Drivers/drivers/drv_gpio.c
@@ -394,8 +394,6 @@ static rt_err_t stm32_pin_irq_enable(struct rt_device *device, rt_base_t pin,
     const struct pin_irq_map *irqmap;
     rt_base_t level;
     rt_int32_t irqindex = -1;
-    GPIO_InitTypeDef GPIO_InitStruct;
-    HAL_GPIO_Init(PIN_STPORT(pin), &GPIO_InitStruct);
 
     if (PIN_PORT(pin) >= PIN_STPORT_MAX)
     {
@@ -419,6 +417,7 @@ static rt_err_t stm32_pin_irq_enable(struct rt_device *device, rt_base_t pin,
         }
 
         irqmap = &pin_irq_map[irqindex];
+        GPIO_InitTypeDef GPIO_InitStruct;
 
         /* Configure GPIO_InitStructure */
         GPIO_InitStruct.Pin = PIN_STPIN(pin);
@@ -438,6 +437,7 @@ static rt_err_t stm32_pin_irq_enable(struct rt_device *device, rt_base_t pin,
             GPIO_InitStruct.Mode = GPIO_MODE_IT_RISING_FALLING;
             break;
         }
+        HAL_GPIO_Init(PIN_STPORT(pin), &GPIO_InitStruct);
 
         HAL_NVIC_SetPriority(irqmap->irqno, 5, 0);
         HAL_NVIC_EnableIRQ(irqmap->irqno);

Original file line number	Diff line number	Diff line change
`@@ -394,8 +394,6 @@ static rt_err_t stm32_pin_irq_enable(struct rt_device *device, rt_base_t pin,`
`394`	`394`	`const struct pin_irq_map *irqmap;`
`395`	`395`	`rt_base_t level;`
`396`	`396`	`rt_int32_t irqindex = -1;`
`397`		`- GPIO_InitTypeDef GPIO_InitStruct;`
`398`		`- HAL_GPIO_Init(PIN_STPORT(pin), &GPIO_InitStruct);`
`399`	`397`
`400`	`398`	`if (PIN_PORT(pin) >= PIN_STPORT_MAX)`
`401`	`399`	`{`
`@@ -419,6 +417,7 @@ static rt_err_t stm32_pin_irq_enable(struct rt_device *device, rt_base_t pin,`
`419`	`417`	`}`
`420`	`418`
`421`	`419`	`irqmap = &pin_irq_map[irqindex];`
	`420`	`+ GPIO_InitTypeDef GPIO_InitStruct;`
`422`	`421`
`423`	`422`	`/* Configure GPIO_InitStructure */`
`424`	`423`	`GPIO_InitStruct.Pin = PIN_STPIN(pin);`
`@@ -438,6 +437,7 @@ static rt_err_t stm32_pin_irq_enable(struct rt_device *device, rt_base_t pin,`
`438`	`437`	`GPIO_InitStruct.Mode = GPIO_MODE_IT_RISING_FALLING;`
`439`	`438`	`break;`
`440`	`439`	`}`
	`440`	`+ HAL_GPIO_Init(PIN_STPORT(pin), &GPIO_InitStruct);`
`441`	`441`
`442`	`442`	`HAL_NVIC_SetPriority(irqmap->irqno, 5, 0);`
`443`	`443`	`HAL_NVIC_EnableIRQ(irqmap->irqno);`