Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes to the paper #317

Closed
10 tasks done
srmnitc opened this issue Aug 19, 2024 · 2 comments
Closed
10 tasks done

Changes to the paper #317

srmnitc opened this issue Aug 19, 2024 · 2 comments
Assignees
@djs0109
Labels
bug Something isn't working

Comments

@srmnitc
Copy link

srmnitc commented Aug 19, 2024 •
edited by djs0109
Loading

This is part of review at openjournals/joss-reviews#6953

Some small change recommendations to the paper:

  • - authors: please add ORCids
  • - line 11: could be strengthened with a citation
  • - line 15-16: please add citations/links for NGSI-v2, Orion Content Broker, QuantumLeap
  • - table 1: could be nice to have the name of the library along with citation
  • - line 48: 'does not' -> 'do not'
  • - line 50: 'continue to' -> 'continues to'
  • - line 75: is _ needed in conversion factor?
  • - line 118: Is PID mentioned before? please check
  • - line 148: missing year in reference
  • - line 169: journal abbreviation, some our full names. Please choose one for consistency.

Thanks a lot for your efforts!
@srmnitc srmnitc added the bug Something isn't working label Aug 19, 2024
@djs0109 djs0109 self-assigned this Aug 26, 2024
@github-actions GitHub Actions
Copy link

Branch 317-Changes-to-the-paper created!

@djs0109
Copy link
Contributor

djs0109 commented Aug 26, 2024

Merged into JOSS_submission

@djs0109 djs0109 closed this as completed Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@djs0109 djs0109

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@srmnitc @djs0109