chore: example to create secure fiware header #319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djs0109
requested changes
Sep 24, 2024
| SERVICE_PATH = '/' | ||
| CLIENT_ID = 'client_id' | ||
| CLIENT_SECRET = 'client_secret' | ||
| KEYCLOAK_HOST = 'https://keycloak.example.com' |
There was a problem hiding this comment.
@sbanoeon could you generally add some hints for example here, TODO: adapt it to your authentication endpoint
| @@ -0,0 +1,111 @@ | |||
| import os | |||
There was a problem hiding this comment.
@sbanoeon, could you add a short description of what this example is about at the beginning? Just make sure the style aligns with the other examples we already have
| authorization='Bearer %s' % token) | ||
|
|
||
| # create a context broker client | ||
| cb_client = ContextBrokerClient(url=CB_URL, fiware_header=fiware_header, session=session) |
There was a problem hiding this comment.
@sbanoeon could you add some get/put requests here to show that the request does not need to be adapted. By the way, the token must be consistently queried, right? If so, please also add a hints regarding this
|
The rest looks good to me! |
djs0109
approved these changes
Oct 22, 2024
djs0109
requested changes
Oct 22, 2024
djs0109
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.