Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Essential checks introduction for hooks and groups in recipe #1795

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

asn1809
Copy link
Member

@asn1809 asn1809 commented Feb 3, 2025

When using recipe, hooks and group can be either essential or not. It is defined either as group.Essential or hook.Essential. It is used in combination with workflow.FailOn.

The supported values for FailOn are:

  1. "any-error" -- Meaning for any of the error seen in the workflow steps mentioned in sequence, fail the workflow.
  2. "essential-error" -- Meaning if hook or group is marked as essential and any of essential steps fail, then the workflow fails.
  3. "full-error" -- Meaning if all the essential hooks or groups in the sequence fail, then only workflow fails. If any one of the essential passes, then the overall workflow should be marked as successful.

Fixes #1762 and #1760

@asn1809 asn1809 force-pushed the asn-hook-essential-fix branch from a27ce0f to 0f931ff Compare February 3, 2025 20:16
@asn1809 asn1809 force-pushed the asn-hook-essential-fix branch from 0f931ff to c91198f Compare February 3, 2025 20:24
@asn1809 asn1809 force-pushed the asn-hook-essential-fix branch from c91198f to 7f4602b Compare February 4, 2025 05:42
@asn1809 asn1809 marked this pull request as ready for review February 4, 2025 05:47
@asn1809 asn1809 force-pushed the asn-hook-essential-fix branch from 7f4602b to d94908e Compare February 4, 2025 18:23
Signed-off-by: Annaraya Narasagond <[email protected]>
@asn1809 asn1809 force-pushed the asn-hook-essential-fix branch from d94908e to 8ef861a Compare February 4, 2025 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Verify the behaviour of workflows/failOn
2 participants