Update error response and tests

Author: jamiebenstead

lib/concepts/feedback/set_read.rb

@@ -11,7 +11,7 @@ def call(feedback:)
         response
       rescue StandardError => e
         Sentry.capture_exception(e)
-        response[:error] = response[:feedback]&.errors
+        response[:error] = e.message
         response
       end
     end

spec/concepts/feedback/set_read_at_spec.rb

@@ -14,7 +14,7 @@
 
       it 'returns the updated feedback' do
         response = described_class.call(feedback: feedback)
-        expect(response[:feedback]).to eq(feedback)
+        expect(response[:feedback]).to be_a(Feedback)
       end
 
       it 'returns read_at' do
@@ -30,28 +30,23 @@
 
     context 'when set_read fails' do
       before do
-        allow(feedback).to receive(:save!).and_raise(StandardError, 'Transition failed')
+        allow(feedback).to receive(:save!).and_raise(StandardError, 'Some API error')
       end
 
       it 'returns a failed operation response' do
         response = described_class.call(feedback: feedback)
         expect(response.success?).to be(false)
       end
 
-      it 'returns the original feedback' do
-        response = described_class.call(feedback: feedback)
-        expect(response[:feedback]).to eq(feedback)
-      end
-
       it 'does not persist read_at' do
         described_class.call(feedback: feedback)
         feedback.reload
         expect(feedback.read_at).to be_nil
       end
 
-      it 'includes an error object in the response' do
+      it 'includes the correct error response' do
         response = described_class.call(feedback: feedback)
-        expect(response[:error]).to be_a(ActiveModel::Errors)
+        expect(response[:error]).to eq('Some API error')
       end
     end
   end

spec/features/feedback/setting_read_at_spec.rb

@@ -44,28 +44,44 @@
   context 'when logged in as the student' do
     before do
       authenticated_in_hydra_as(student)
-      put("/api/projects/#{student_project.identifier}/feedback/#{feedback.id}/read", headers: headers)
-      feedback.reload
     end
 
-    it 'returns ok response' do
-      expect(response).to have_http_status(:ok)
-    end
+    context 'when feedback exists' do
+      before do
+        put("/api/projects/#{student_project.identifier}/feedback/#{feedback.id}/read", headers: headers)
+        feedback.reload
+      end
 
-    it 'returns the feedback json' do
-      expect(response.body).to eq(feedback_json)
-    end
+      it 'returns ok response' do
+        expect(response).to have_http_status(:ok)
+      end
 
-    it 'does set the read_at on feedback' do
-      expect(feedback.read_at).to be_present
-    end
+      it 'returns the feedback json' do
+        expect(response.body).to eq(feedback_json)
+      end
+
+      it 'does set the read_at on feedback' do
+        expect(feedback.read_at).to be_present
+      end
 
-    it 'sets read_at to be a time' do
-      expect(feedback.read_at).to be_a(ActiveSupport::TimeWithZone)
+      it 'sets read_at to be a time' do
+        expect(feedback.read_at).to be_a(ActiveSupport::TimeWithZone)
+      end
+
+      it 'sets read_at to a recent time' do
+        expect(feedback.read_at).to be_within(5.seconds).of(Time.current)
+      end
     end
 
-    it 'sets read_at to a recent time' do
-      expect(feedback.read_at).to be_within(5.seconds).of(Time.current)
+    context 'when feedback does not exist' do
+      before do
+        put("/api/projects/#{student_project.identifier}/feedback/does-not-exist/read", headers: headers)
+        feedback.reload
+      end
+
+      it 'returns not found response' do
+        expect(response).to have_http_status(:not_found)
+      end
     end
   end
 end