Fix-project-importer (#495)

## Status

#closes #496
## What's changed?

Fixes a bug in the project_importer, where the media wasn't purged
Ensures that top level graphql errors are surfaced

## Steps to perform after deploying to production

N/A

Author: danhalson

app/jobs/upload_job.rb

@@ -75,16 +75,33 @@ def load_projects_data(locale, repository, owner)
       variables: { repository:, owner:, expression: "#{ENV.fetch('GITHUB_WEBHOOK_REF')}:#{locale}/code" }
     )
 
-    if response.data.errors.any?
-      error_messages = response.data.errors.messages.map { |error| error }
-      error_details = response.data.errors.details.map { |error| error }
-      error_type = error_details.dig(0, 1, 0, 'type')
+    handle_graphql_errors(response)
+    response
+  end
 
-      # Handle NOT_FOUND errors as a special case, as this can happen when the repo is first created
-      raise GraphQL::Client::Error, "GraphQL query failed with errors: #{error_messages}. Details: #{error_details}" unless error_type == 'NOT_FOUND'
-    end
+  def handle_graphql_errors(response)
+    errors = response&.errors.presence || response&.data&.errors
+    return if errors.blank?
 
-    response
+    error_messages, error_details, error_type = extract_error_info(errors)
+
+    # Handle NOT_FOUND errors as a special case, as this can happen when the repo is first created
+    raise GraphQL::Client::Error, "GraphQL query failed with errors: #{error_messages}. Details: #{error_details}" unless error_type == 'NOT_FOUND'
+  end
+
+  def extract_error_info(errors)
+    error_type = nil
+    if errors.is_a?(Array) && errors.first.is_a?(Hash)
+      # Query level error
+      error_messages = errors.map { |error| error }
+      error_details = errors.map { |error| error }
+      error_type = error_details.dig(0, 1, 0, 'type')
+    else
+      # Top level error
+      error_messages = errors.messages['data'].first
+      error_details = errors.details['data'].first['message']
+    end
+    [error_messages, error_details, error_type]
   end
 
   def format_project(project_dir, locale, repository, owner)

lib/project_importer.rb

@@ -69,7 +69,7 @@ def attach_media_if_needed
       if existing_media_file
         next if existing_media_file.blob.checksum == media_checksum(media_file[:io])
 
-        existing_media.purge
+        existing_media_file.purge
       end
       if images.include?(media_file)
         project.images.attach(**media_file)