Skip to content

Commit d1d009c

Browse files
authored
Merge pull request #528 from kukchanka/fix-maximum-update-depth-exceeded
fix(getPosition): updated getPosition to fix 'maximum update depth'
2 parents 59a589e + 8fda305 commit d1d009c

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

src/utils/getPosition.js

+3-2
Original file line numberDiff line numberDiff line change
@@ -86,10 +86,11 @@ export default function (e, target, node, place, desiredPlace, effect, offset) {
8686

8787
let isNewState = false
8888
let newPlace
89-
if (inside(desiredPlace) && desiredPlace !== place) {
89+
let shouldUpdatePlace = desiredPlace !== place
90+
if (inside(desiredPlace) && shouldUpdatePlace) {
9091
isNewState = true
9192
newPlace = desiredPlace
92-
} else if (insideList.length > 0 && outside(desiredPlace) && outside(place)) {
93+
} else if (insideList.length > 0 && shouldUpdatePlace && outside(desiredPlace) && outside(place)) {
9394
isNewState = true
9495
newPlace = insideList[0]
9596
}

0 commit comments

Comments
 (0)