Skip to content

Commit b96d5c6

Browse files
committed
Removed unused InferTargetTypes requirement from InstructionDefinition
1 parent 99453c7 commit b96d5c6

File tree

3 files changed

+3
-18
lines changed

3 files changed

+3
-18
lines changed

gen/instruction_definition.go

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -24,22 +24,4 @@ type BaseInstruction interface {
2424
type InstructionDefinition interface {
2525
// Build an instruction from the provided instruction information.
2626
BuildInstruction(info *InstructionInfo) (BaseInstruction, core.ResultList)
27-
28-
// Provided a list a list of types that correspond to argument types,
29-
// and a (possibly partial) list of target types, return a complete list
30-
// of target types which is implicitly inferred from the argument types,
31-
// and possibly the explicit target types, or an error if the target types
32-
// can not be inferred.
33-
//
34-
// On success, the length of the returned type slice should be equal to the
35-
// provided (partial) targets length. The non nil provided target types
36-
// should not be modified.
37-
//
38-
// TODO: perhaps we should not pass the bare generation context to the "public"
39-
// instruction set definition API, and should wrap it with a limited interface.
40-
InferTargetTypes(
41-
ctx *FunctionGenerationContext,
42-
targets []*ReferencedTypeInfo,
43-
arguments []*ReferencedTypeInfo,
44-
) ([]ReferencedTypeInfo, core.ResultList)
4527
}

go.mod

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ module alon.kr/x/usm
33
go 1.23.0
44

55
require (
6+
alon.kr/x/aarch64codegen v0.0.0-20250208154601-95698b4bcdcf
67
alon.kr/x/list v0.0.0-20241203223347-3173d76828c0
78
alon.kr/x/set v0.0.0-20250105200711-55a9ad95f635
89
alon.kr/x/stack v0.0.0-20241231201659-c96903670d6f

go.sum

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
alon.kr/x/aarch64codegen v0.0.0-20250208154601-95698b4bcdcf h1:awNAJd+L3bRbMbcsPlPdyaEDu4/GQFK8xlKMgDosEhQ=
2+
alon.kr/x/aarch64codegen v0.0.0-20250208154601-95698b4bcdcf/go.mod h1:WAdZYqOdp9KwoBjWamrMDAphahR5oXkPSICj3+tLIyQ=
13
alon.kr/x/list v0.0.0-20241203223347-3173d76828c0 h1:NedGw3ZJMKT9Y4RByuogGfBEXT4st8eX/XO5frezx6o=
24
alon.kr/x/list v0.0.0-20241203223347-3173d76828c0/go.mod h1:7syBFMuVmxetKppmlKe6nQlp2BRueprI1r8/d7GB7fs=
35
alon.kr/x/set v0.0.0-20250105200711-55a9ad95f635 h1:qSmfYQ1/emk5FQ9GF1rEsDTzPHHICrwojgfXCmszdww=

0 commit comments

Comments
 (0)