Skip to content

Commit

Permalink
Removed unused InferTargetTypes requirement from `InstructionDefini…
Browse files Browse the repository at this point in the history
…tion`
  • Loading branch information
RealA10N committed Feb 9, 2025
1 parent 99453c7 commit b96d5c6
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 18 deletions.
18 changes: 0 additions & 18 deletions gen/instruction_definition.go
Original file line number Diff line number Diff line change
Expand Up @@ -24,22 +24,4 @@ type BaseInstruction interface {
type InstructionDefinition interface {
// Build an instruction from the provided instruction information.
BuildInstruction(info *InstructionInfo) (BaseInstruction, core.ResultList)

// Provided a list a list of types that correspond to argument types,
// and a (possibly partial) list of target types, return a complete list
// of target types which is implicitly inferred from the argument types,
// and possibly the explicit target types, or an error if the target types
// can not be inferred.
//
// On success, the length of the returned type slice should be equal to the
// provided (partial) targets length. The non nil provided target types
// should not be modified.
//
// TODO: perhaps we should not pass the bare generation context to the "public"
// instruction set definition API, and should wrap it with a limited interface.
InferTargetTypes(
ctx *FunctionGenerationContext,
targets []*ReferencedTypeInfo,
arguments []*ReferencedTypeInfo,
) ([]ReferencedTypeInfo, core.ResultList)
}
1 change: 1 addition & 0 deletions go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ module alon.kr/x/usm
go 1.23.0

require (
alon.kr/x/aarch64codegen v0.0.0-20250208154601-95698b4bcdcf
alon.kr/x/list v0.0.0-20241203223347-3173d76828c0
alon.kr/x/set v0.0.0-20250105200711-55a9ad95f635
alon.kr/x/stack v0.0.0-20241231201659-c96903670d6f
Expand Down
2 changes: 2 additions & 0 deletions go.sum
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
alon.kr/x/aarch64codegen v0.0.0-20250208154601-95698b4bcdcf h1:awNAJd+L3bRbMbcsPlPdyaEDu4/GQFK8xlKMgDosEhQ=
alon.kr/x/aarch64codegen v0.0.0-20250208154601-95698b4bcdcf/go.mod h1:WAdZYqOdp9KwoBjWamrMDAphahR5oXkPSICj3+tLIyQ=
alon.kr/x/list v0.0.0-20241203223347-3173d76828c0 h1:NedGw3ZJMKT9Y4RByuogGfBEXT4st8eX/XO5frezx6o=
alon.kr/x/list v0.0.0-20241203223347-3173d76828c0/go.mod h1:7syBFMuVmxetKppmlKe6nQlp2BRueprI1r8/d7GB7fs=
alon.kr/x/set v0.0.0-20250105200711-55a9ad95f635 h1:qSmfYQ1/emk5FQ9GF1rEsDTzPHHICrwojgfXCmszdww=
Expand Down

0 comments on commit b96d5c6

Please sign in to comment.