Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] Create typography and base styles for design system #1432

Open
3 tasks
markcaron opened this issue Jan 17, 2024 · 2 comments
Open
3 tasks

[feat] Create typography and base styles for design system #1432

markcaron opened this issue Jan 17, 2024 · 2 comments
Assignees
Labels
feature New feature or request for design Design work is requested needs discovery Needs discovery priority: high High priority

Comments

@markcaron
Copy link
Collaborator

markcaron commented Jan 17, 2024

We need typography and general base styles for use within the design system. End solution should be a base stylesheet that we can add to our CDN or implementors can include in their sites/apps.

  • Discovery CSS solution
  • Design: define styles
  • Dev: write CSS

Related issues:

@markcaron markcaron changed the title Create typography and base styles for design system [feat] Create typography and base styles for design system Jan 17, 2024
@markcaron markcaron added feature New feature or request for design Design work is requested needs discovery Needs discovery priority: high High priority needs refinement This issue needs to be refined labels Jan 17, 2024
@markcaron markcaron added this to the 2024/Q1 — Chansey release milestone Jan 17, 2024
@markcaron
Copy link
Collaborator Author

markcaron commented Jan 22, 2024

Discussed in office hours:

  • Have multiple CSS files, like reset.css, typography.css, page.css, grid.css, etc.
  • Bundle base CSS files in post process on CDN in a separate bundles directory, like rhds-all.css
  • Pattern-based styles for lightDOM would exist in rhds/patterns/${pattern-name}/${pattern-name}.css

CSS files could potentially live in rhds/utilities/styles

@markcaron
Copy link
Collaborator Author

markcaron commented Jan 22, 2024

Question:
Do we need a tokens.css to act as the interface for the semantic tokens used in typography.css, pages.css, etc.?

Or do we reference the primitive directly?

h1 {
  font-size: var(--rh-font-size-heading-2xl, 3rem);
}

vs

h1 {
  font-size: var(--rh-font-size-h1, var(--rh-font-size-heading-2xl, 3rem));
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request for design Design work is requested needs discovery Needs discovery priority: high High priority
Projects
Status: In Progress 🟢
Status: In Progress 🟢
Development

No branches or pull requests

4 participants