Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] Change uppercase titles to sentence case #1650

Closed
3 tasks done
marionnegp opened this issue Jun 20, 2024 · 3 comments · Fixed by #2160
Closed
3 tasks done

[feat] Change uppercase titles to sentence case #1650

marionnegp opened this issue Jun 20, 2024 · 3 comments · Fixed by #2160
Assignees
Labels
docs Improvements or additions to documentation feature New feature or request for dev Ready for development

Comments

@marionnegp
Copy link
Collaborator

marionnegp commented Jun 20, 2024

Description

Text shouldn't be using uppercase, based on brand guidelines. Headings should use sentence instead.

Suggested solution

Remove any CSS that forces headings to be in all caps. The components that may be affected are:

  • rh-card
  • rh-stat
  • rh-tile

docs updates: #2165

Example API

No response

Additional context

@coreyvickery, we will have to update this in the Figma library and let other designers know once guidelines go up on ux.redhat.com.

@marionnegp marionnegp added the feature New feature or request label Jun 20, 2024
@bennypowers
Copy link
Member

seems like this will mostly only affect patterns. here are all the occurrences of uppercase in the repo

❯ rg uppercase
elements/rh-site-status/rh-site-status.css
32:  text-transform: uppercase;

elements/rh-tile/rh-tile.css
239:  text-transform: uppercase;

elements/rh-card/demo/variants.html
152:      text-transform: uppercase;

elements/rh-card/demo/color-context.html
93:        text-transform: uppercase;

elements/rh-jump-links/docs/10-style.md
7:the uppercase label on top.

elements/rh-stat/rh-stat.css
57:  text-transform: uppercase;

docs/styles/not-defined.css
11:  text-transform: uppercase;

docs/foundations/typography.md
38:    text-transform: uppercase;

docs/patterns/card/index.md
38:    text-transform: uppercase;
45:    text-transform: uppercase;
52:    text-transform: uppercase;

docs/assets/javascript/elements/uxdot-hero.js
27:      text-transform: uppercase;

so it looks like site-status and tile have some uppercase styles at runtime

@marionnegp marionnegp added docs Improvements or additions to documentation for design Design work is requested for dev Ready for development labels Jun 21, 2024
@marionnegp
Copy link
Collaborator Author

@markcaron, is this something that we can do for the Chansey release?

@markcaron markcaron added needs prioritization This issue needs prioritization and removed for design Design work is requested labels Jan 9, 2025
@markcaron markcaron assigned ArathyKumar and unassigned markcaron Jan 9, 2025
@markcaron markcaron removed the needs prioritization This issue needs prioritization label Jan 9, 2025
@bennypowers
Copy link
Member

@bennypowers bennypowers linked a pull request Feb 10, 2025 that will close this issue
@github-project-automation github-project-automation bot moved this from Backlog to Done ☑️ in Red Hat Design System Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation feature New feature or request for dev Ready for development
Projects
Status: Done ☑️
Development

Successfully merging a pull request may close this issue.

4 participants