Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] <rh-subnav> dark themes aren't supported, causing accessibility issues #2188

Open
markcaron opened this issue Feb 27, 2025 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@markcaron
Copy link
Collaborator

markcaron commented Feb 27, 2025

Describe the bug

Dark mode theming from parent element isn't supported in <rh-subnav>, which causes accessibility issues too.

Also related: document its support: #1479

Screenshots

Image

Steps to reproduce

  1. Go to Subnav's context demo
  2. Switch to dark theme
  3. See brokenness

Expected behaviour

Need to add dark mode theming support based on parent element's context.

Element HTML

Operating System (OS)

macOS

Browser

Chrome

Additional browser or assistive technology info

No response

@markcaron markcaron added the bug Something isn't working label Feb 27, 2025
@markcaron markcaron added this to the 2025/Q1 — Cubone release milestone Feb 27, 2025
@markcaron markcaron self-assigned this Feb 27, 2025
@zeroedin
Copy link
Collaborator

You can change <rh-subnav color-palette="darkest"> and it works however it will not respond to its parent context as it defaults to lightest.

@markcaron markcaron linked a pull request Feb 27, 2025 that will close this issue
@markcaron markcaron moved this from Backlog to Review 🔍 in Red Hat Design System Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Review 🔍
Development

Successfully merging a pull request may close this issue.

2 participants