Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] <rh-tile> icon slot fixes #2191

Open
marionnegp opened this issue Feb 27, 2025 · 0 comments
Open

[bug] <rh-tile> icon slot fixes #2191

marionnegp opened this issue Feb 27, 2025 · 0 comments
Labels
bug Something isn't working

Comments

@marionnegp
Copy link
Collaborator

marionnegp commented Feb 27, 2025

Describe the bug

Migrating some questions from #2082 to address in this separate issue:

  • There's a discrepancy between the slotted svg element and the slot element it projects into, which have different styles. This is causing the space below the icon slot to appear larger than it's supposed to. Here's a screenshot of a tile demo from fix(tile): compact link icon layout #2082's DP with a spacer.
    Image

  • Do we need a demo with the icon using an interactive color? We might be able to remove it. The original design intended for the icon to use either the primary or secondary icon color, which would not change color as the user interacted with tile.

Screenshots

No response

Steps to reproduce

Check this tile with icon demo from #2082. (This demo might be live on ux.redhat.com by the time this issue is worked on.)

Expected behaviour

  • Space between icon slot and any other content slot in tile should be --rh-space-2xl.
  • Icons in the icon slot should avoid using the interactive icon colors. Perhaps this needs to be added to the docs as well.

Element HTML

Operating System (OS)

macOS

Browser

No response

Additional browser or assistive technology info

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Backlog
Development

No branches or pull requests

1 participant