-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat]: <rh-jump-links>
ready to migrate
#539
Comments
@bennypowers I believe you had an idea on implementation on this, so we'll need your advisement. |
@coreyvickery and I will have to update the docs too. |
While discussing Jump Links with @Nouveau today, we realized that we're likely going to run into an issue with Jump Links and |
<rh-jump-links>
ready to migrate
On my smaller laptop screen, jump links with many items end up getting cut off. The jump links on the All products page just barely fits if I make my window fullscreen. Dan suggested potentially decreasing the padding for each item. |
After our We discussed the following problems:
And we came to the following decisions:
|
Waiting on design updates (#7 above) |
@markcaron Marionne will be taking on this work. |
@coreyvickery, here's the mock up of jump links. Not much has changed because most of the accessibility improvements are in guidelines that are specced out in this file as well. The table of contents variation has also been removed as we discussed. For point #7, I added a border only for both light and dark theme to make the design a little easier to theme. |
Resolved at office hours today:
|
@coreyvickery, here are updated to the mockups for jump links. This round includes a vertical sticky jump link. |
@marionnegp All looks good to me. Would you be able to tackle the docs? |
@coreyvickery, yep, I can do docs. |
Tag Name
pfe-jump-links
RHDS Only
Additional Info
<rh-jump-links>
from<pfe-jump-links>
.Current design specs
2022 study about jump links on redhat.com
To do
The text was updated successfully, but these errors were encountered: