Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up C# warnings #1

Open
RedMser opened this issue Nov 13, 2024 · 0 comments
Open

Clean up C# warnings #1

RedMser opened this issue Nov 13, 2024 · 0 comments
Labels
cli C# command line tool enhancement New feature or request good first issue Good for newcomers

Comments

@RedMser
Copy link
Owner

RedMser commented Nov 13, 2024 •
edited
Loading

While the current code works, it is not ideal.

  • No namespaces (some class names are prefixed with "Write" because of this, to avoid conflicts)
  • Multiple classes in one file
  • Misc warnings like nullability stuff
  • Trim warnings (not sure if those can be truly fixed from our side)

I don't intend to modify the code much more (beyond what's necessary to keep up with features and game updates), so it might be a good time to clean it up now.
@RedMser RedMser added enhancement New feature or request good first issue Good for newcomers cli C# command line tool labels Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cli C# command line tool enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@RedMser