Warnings supression and deletion of unnecessary check in some LAPACKE xLARFB functions

jgpallero · jgpallero · commit 08f7efeba844 · 2023-01-13T23:39:24.000+01:00
diff --git a/LAPACKE/src/lapacke_clarfb.c b/LAPACKE/src/lapacke_clarfb.c
@@ -60,7 +60,7 @@ lapack_int LAPACKE_clarfb( int matrix_layout, char side, char trans, char direct
         ncols_v = ( !col && left ) ? m : ( ( !col && !left ) ? n : ( col ? k : 1 ) );
         uplo = ( ( left && col ) || !( left || col ) ) ? 'l' : 'u';
 
-        if( !forward && ( col && k > nrows_v ) || ( !col && k > ncols_v )) {
+        if( ( col && k > nrows_v ) || ( !col && k > ncols_v ) ) {
             LAPACKE_xerbla( "LAPACKE_clarfb", -8 );
             return -8;
         }
diff --git a/LAPACKE/src/lapacke_clarfb_work.c b/LAPACKE/src/lapacke_clarfb_work.c
@@ -81,7 +81,7 @@ lapack_int LAPACKE_clarfb_work( int matrix_layout, char side, char trans,
             LAPACKE_xerbla( "LAPACKE_clarfb_work", info );
             return info;
         }
-        if( !forward && ( col && k > nrows_v ) || ( !col && k > ncols_v )) {
+        if( ( col && k > nrows_v ) || ( !col && k > ncols_v ) ) {
             info = -8;
             LAPACKE_xerbla( "LAPACKE_clarfb_work", info );
             return info;
diff --git a/LAPACKE/src/lapacke_dlarfb.c b/LAPACKE/src/lapacke_dlarfb.c
@@ -59,7 +59,7 @@ lapack_int LAPACKE_dlarfb( int matrix_layout, char side, char trans, char direct
         ncols_v = ( !col && left ) ? m : ( ( !col && !left ) ? n : ( col ? k : 1 ) );
         uplo = ( ( left && col ) || !( left || col ) ) ? 'l' : 'u';
 
-        if( !forward && ( col && k > nrows_v ) || ( !col && k > ncols_v )) {
+        if( ( col && k > nrows_v ) || ( !col && k > ncols_v ) ) {
             LAPACKE_xerbla( "LAPACKE_dlarfb", -8 );
             return -8;
         }
diff --git a/LAPACKE/src/lapacke_dlarfb_work.c b/LAPACKE/src/lapacke_dlarfb_work.c
@@ -80,7 +80,7 @@ lapack_int LAPACKE_dlarfb_work( int matrix_layout, char side, char trans,
             LAPACKE_xerbla( "LAPACKE_dlarfb_work", info );
             return info;
         }
-        if( !forward && ( col && k > nrows_v ) || ( !col && k > ncols_v )) {
+        if( ( col && k > nrows_v ) || ( !col && k > ncols_v ) ) {
             info = -8;
             LAPACKE_xerbla( "LAPACKE_dlarfb_work", info );
             return info;
diff --git a/LAPACKE/src/lapacke_slarfb.c b/LAPACKE/src/lapacke_slarfb.c
@@ -59,7 +59,7 @@ lapack_int LAPACKE_slarfb( int matrix_layout, char side, char trans, char direct
         ncols_v = ( !col && left ) ? m : ( ( !col && !left ) ? n : ( col ? k : 1 ) );
         uplo = ( ( left && col ) || !( left || col ) ) ? 'l' : 'u';
 
-        if( !forward && ( col && k > nrows_v ) || ( !col && k > ncols_v )) {
+        if( ( col && k > nrows_v ) || ( !col && k > ncols_v ) ) {
             LAPACKE_xerbla( "LAPACKE_slarfb", -8 );
             return -8;
         }
diff --git a/LAPACKE/src/lapacke_slarfb_work.c b/LAPACKE/src/lapacke_slarfb_work.c
@@ -80,7 +80,7 @@ lapack_int LAPACKE_slarfb_work( int matrix_layout, char side, char trans,
             LAPACKE_xerbla( "LAPACKE_slarfb_work", info );
             return info;
         }
-        if( !forward && ( col && k > nrows_v ) || ( !col && k > ncols_v )) {
+        if( ( col && k > nrows_v ) || ( !col && k > ncols_v ) ) {
             info = -8;
             LAPACKE_xerbla( "LAPACKE_slarfb_work", info );
             return info;
diff --git a/LAPACKE/src/lapacke_zlarfb.c b/LAPACKE/src/lapacke_zlarfb.c
@@ -60,7 +60,7 @@ lapack_int LAPACKE_zlarfb( int matrix_layout, char side, char trans, char direct
         ncols_v = ( !col && left ) ? m : ( ( !col && !left ) ? n : ( col ? k : 1 ) );
         uplo = ( ( left && col ) || !( left || col ) ) ? 'l' : 'u';
 
-        if( !forward && ( col && k > nrows_v ) || ( !col && k > ncols_v )) {
+        if( ( col && k > nrows_v ) || ( !col && k > ncols_v ) ) {
             LAPACKE_xerbla( "LAPACKE_zlarfb", -8 );
             return -8;
         }
diff --git a/LAPACKE/src/lapacke_zlarfb_work.c b/LAPACKE/src/lapacke_zlarfb_work.c
@@ -81,7 +81,7 @@ lapack_int LAPACKE_zlarfb_work( int matrix_layout, char side, char trans,
             LAPACKE_xerbla( "LAPACKE_zlarfb_work", info );
             return info;
         }
-        if( !forward && ( col && k > nrows_v ) || ( !col && k > ncols_v )) {
+        if( ( col && k > nrows_v ) || ( !col && k > ncols_v ) ) {
             info = -8;
             LAPACKE_xerbla( "LAPACKE_zlarfb_work", info );
             return info;

Original file line number	Diff line number	Diff line change
`@@ -60,7 +60,7 @@ lapack_int LAPACKE_clarfb( int matrix_layout, char side, char trans, char direct`
`60`	`60`	`ncols_v = ( !col && left ) ? m : ( ( !col && !left ) ? n : ( col ? k : 1 ) );`
`61`	`61`	`uplo = ( ( left && col ) \|\| !( left \|\| col ) ) ? 'l' : 'u';`
`62`	`62`
`63`		`- if( !forward && ( col && k > nrows_v ) \|\| ( !col && k > ncols_v )) {`
	`63`	`+ if( ( col && k > nrows_v ) \|\| ( !col && k > ncols_v ) ) {`
`64`	`64`	`LAPACKE_xerbla( "LAPACKE_clarfb", -8 );`
`65`	`65`	`return -8;`
`66`	`66`	`}`
Original file line number	Diff line number	Diff line change
`@@ -81,7 +81,7 @@ lapack_int LAPACKE_clarfb_work( int matrix_layout, char side, char trans,`
`81`	`81`	`LAPACKE_xerbla( "LAPACKE_clarfb_work", info );`
`82`	`82`	`return info;`
`83`	`83`	`}`
`84`		`- if( !forward && ( col && k > nrows_v ) \|\| ( !col && k > ncols_v )) {`
	`84`	`+ if( ( col && k > nrows_v ) \|\| ( !col && k > ncols_v ) ) {`
`85`	`85`	`info = -8;`
`86`	`86`	`LAPACKE_xerbla( "LAPACKE_clarfb_work", info );`
`87`	`87`	`return info;`
Original file line number	Diff line number	Diff line change
`@@ -59,7 +59,7 @@ lapack_int LAPACKE_dlarfb( int matrix_layout, char side, char trans, char direct`
`59`	`59`	`ncols_v = ( !col && left ) ? m : ( ( !col && !left ) ? n : ( col ? k : 1 ) );`
`60`	`60`	`uplo = ( ( left && col ) \|\| !( left \|\| col ) ) ? 'l' : 'u';`
`61`	`61`
`62`		`- if( !forward && ( col && k > nrows_v ) \|\| ( !col && k > ncols_v )) {`
	`62`	`+ if( ( col && k > nrows_v ) \|\| ( !col && k > ncols_v ) ) {`
`63`	`63`	`LAPACKE_xerbla( "LAPACKE_dlarfb", -8 );`
`64`	`64`	`return -8;`
`65`	`65`	`}`
Original file line number	Diff line number	Diff line change
`@@ -80,7 +80,7 @@ lapack_int LAPACKE_dlarfb_work( int matrix_layout, char side, char trans,`
`80`	`80`	`LAPACKE_xerbla( "LAPACKE_dlarfb_work", info );`
`81`	`81`	`return info;`
`82`	`82`	`}`
`83`		`- if( !forward && ( col && k > nrows_v ) \|\| ( !col && k > ncols_v )) {`
	`83`	`+ if( ( col && k > nrows_v ) \|\| ( !col && k > ncols_v ) ) {`
`84`	`84`	`info = -8;`
`85`	`85`	`LAPACKE_xerbla( "LAPACKE_dlarfb_work", info );`
`86`	`86`	`return info;`
Original file line number	Diff line number	Diff line change
`@@ -59,7 +59,7 @@ lapack_int LAPACKE_slarfb( int matrix_layout, char side, char trans, char direct`
`59`	`59`	`ncols_v = ( !col && left ) ? m : ( ( !col && !left ) ? n : ( col ? k : 1 ) );`
`60`	`60`	`uplo = ( ( left && col ) \|\| !( left \|\| col ) ) ? 'l' : 'u';`
`61`	`61`
`62`		`- if( !forward && ( col && k > nrows_v ) \|\| ( !col && k > ncols_v )) {`
	`62`	`+ if( ( col && k > nrows_v ) \|\| ( !col && k > ncols_v ) ) {`
`63`	`63`	`LAPACKE_xerbla( "LAPACKE_slarfb", -8 );`
`64`	`64`	`return -8;`
`65`	`65`	`}`
Original file line number	Diff line number	Diff line change
`@@ -80,7 +80,7 @@ lapack_int LAPACKE_slarfb_work( int matrix_layout, char side, char trans,`
`80`	`80`	`LAPACKE_xerbla( "LAPACKE_slarfb_work", info );`
`81`	`81`	`return info;`
`82`	`82`	`}`
`83`		`- if( !forward && ( col && k > nrows_v ) \|\| ( !col && k > ncols_v )) {`
	`83`	`+ if( ( col && k > nrows_v ) \|\| ( !col && k > ncols_v ) ) {`
`84`	`84`	`info = -8;`
`85`	`85`	`LAPACKE_xerbla( "LAPACKE_slarfb_work", info );`
`86`	`86`	`return info;`
Original file line number	Diff line number	Diff line change
`@@ -60,7 +60,7 @@ lapack_int LAPACKE_zlarfb( int matrix_layout, char side, char trans, char direct`
`60`	`60`	`ncols_v = ( !col && left ) ? m : ( ( !col && !left ) ? n : ( col ? k : 1 ) );`
`61`	`61`	`uplo = ( ( left && col ) \|\| !( left \|\| col ) ) ? 'l' : 'u';`
`62`	`62`
`63`		`- if( !forward && ( col && k > nrows_v ) \|\| ( !col && k > ncols_v )) {`
	`63`	`+ if( ( col && k > nrows_v ) \|\| ( !col && k > ncols_v ) ) {`
`64`	`64`	`LAPACKE_xerbla( "LAPACKE_zlarfb", -8 );`
`65`	`65`	`return -8;`
`66`	`66`	`}`
Original file line number	Diff line number	Diff line change
`@@ -81,7 +81,7 @@ lapack_int LAPACKE_zlarfb_work( int matrix_layout, char side, char trans,`
`81`	`81`	`LAPACKE_xerbla( "LAPACKE_zlarfb_work", info );`
`82`	`82`	`return info;`
`83`	`83`	`}`
`84`		`- if( !forward && ( col && k > nrows_v ) \|\| ( !col && k > ncols_v )) {`
	`84`	`+ if( ( col && k > nrows_v ) \|\| ( !col && k > ncols_v ) ) {`
`85`	`85`	`info = -8;`
`86`	`86`	`LAPACKE_xerbla( "LAPACKE_zlarfb_work", info );`
`87`	`87`	`return info;`