Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filter:null gives unexpected results #59

Closed
jwildfire opened this issue Mar 29, 2017 · 3 comments
Closed

filter:null gives unexpected results #59

jwildfire opened this issue Mar 29, 2017 · 3 comments
Labels
Milestone

Comments

@jwildfire
Copy link
Contributor

Current behaviour: If a user specifies filters:null the default filters are rendered.
Expected behaviour: If a user specifies filters:null no filters are rendered.

Side notes:

  • null is probably a more resonable default for filters
  • filter:[] doesn't render any filters (this is fine)

cc: @bzkrouse

@jwildfire jwildfire added this to the 3.1.0 milestone Mar 29, 2017
@jwildfire jwildfire removed this from the 3.1.0 milestone Jun 22, 2017
@jwildfire jwildfire added this to the v3.3.0 milestone Aug 21, 2018
@jwildfire
Copy link
Contributor Author

jwildfire commented Aug 21, 2018

Possible duplicate of #46

@jwildfire jwildfire added wontfix and removed bug labels Aug 25, 2018
@jwildfire
Copy link
Contributor Author

jwildfire commented Aug 25, 2018

On second thought, I actually think the current behavior here makes sense. I think that a user specifying null should mean: "use the defaults" - the same as if the user not specified anything at all. On the other hand, I think it's reasonable for an empty array to mean: "Ignore the default; I don't want any filters".

On a related note, I think there is a case to be made that we've got too many filters rendered by default, but we can make a different issue for that if folks think it is needed.

@jwildfire
Copy link
Contributor Author

jwildfire commented Aug 25, 2018

Closing as won't fix. #46 is a related, but different issue, so going to handle that separately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants