Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge Settle into Collect #2320

Merged
merged 13 commits into from
Feb 19, 2025
Merged

Merge Settle into Collect #2320

merged 13 commits into from
Feb 19, 2025

Conversation

sanatd33
Copy link
Contributor

Collect now can properly get stationary and moving balls

github-actions bot and others added 2 commits January 19, 2025 21:49
automated style fixes

Co-authored-by: sid-parikh <[email protected]>
Copy link
Contributor

@jacksherling jacksherling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bool path_created_for_dampen_ = false;

// Do we have the ball in the robot
bool is_ball_sense_ = false;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

neat

Copy link
Contributor

@rishiso rishiso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sanatd33 sanatd33 merged commit 298910d into ros2 Feb 19, 2025
2 checks passed
@sanatd33 sanatd33 deleted the settle-collect branch February 19, 2025 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants