Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal ref add penalty kick #2344

Merged
merged 9 commits into from
Feb 26, 2025
Merged

Internal ref add penalty kick #2344

merged 9 commits into from
Feb 26, 2025

Conversation

jvogt23
Copy link
Contributor

@jvogt23 jvogt23 commented Feb 17, 2025

Description

Describe your pull request.
Added penalty kick to internal ref with buttons to match

Associated / Resolved Issue

Resolves # or ClickUp card

Design Documents

Link

Steps to Test

Test Case 1

  1. Step 1
  2. Step 2
  3. Step 3

Expected result:???

Key Files to Review

Group 1

  • File 1
  • File 2

Group 2

  • File 3
  • File 4

Review Checklist

  • Docstrings: All methods and classes should have the file appropriate docstrings which follow the guidelines in the "Contributing" page of our docs.
  • Remove extra print statements: Any print statements used for debugging should be removed
  • Tag reviewers: Tag some people for review and ping them on Slack

(Optional) Sub-issues (for drafts)

Note: if you find yourself breaking this PR into many smaller features, it may make sense to break up the PR into logical units based on these features.

  • Step 1
  • Step 2

Copy link

@piman51277 piman51277 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a minor UI change, LGTM

@rishiso rishiso requested review from rishiso and removed request for jacksherling February 26, 2025 02:24
@rishiso rishiso self-requested a review February 26, 2025 02:30
Copy link
Contributor

@rishiso rishiso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but helper function might be an improvement

Copy link
Contributor

@sanatd33 sanatd33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hype

@sanatd33 sanatd33 merged commit 9981233 into ros2 Feb 26, 2025
2 checks passed
@sanatd33 sanatd33 deleted the internal-ref-fix branch February 26, 2025 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants