Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Subclass of' answers in results #139

Open
karafecho opened this issue Apr 7, 2023 · 3 comments
Open

'Subclass of' answers in results #139

karafecho opened this issue Apr 7, 2023 · 3 comments

Comments

@karafecho
Copy link

karafecho commented Apr 7, 2023

This issue is to suggest that 'subclass of' answers are not returned to users, or are returned in entirety, or are optional. In the example below, the user (me) selected "asthma" as a node, but the top answer was for "occupational asthma", which was not selected. Note that there are many subclasses of asthma, so it is not clear why only one subclass is returned (presumably that was the only one connected to ammonia?). Either provide the user with all known subclasses, or restrict the results to only the selected node, or allow users to select for subclasses (probably the most appealing option).

Note that this is only one example. The issue appears to be general and likely related to the Answer Coalescer or perhaps Name Resolver/Node Normalizer, but it is confusing to users.

image

@cbizon
Copy link
Contributor

cbizon commented Apr 11, 2023

See also #123

@cbizon
Copy link
Contributor

cbizon commented Apr 11, 2023

See also ranking-agent/reasoner-transpiler#72 - do we want to handle this at the transpiler level?

@karafecho
Copy link
Author

I understand the issue now.

FWIW, my suggestion would be to provide users with control over subclass inferences, especially when a high-level node such as "asthma" or "cardiovascular disorder" is selected. For instance, it might be helpful if a popup appeared when users selected a non-specific node to alert them to the fact that they may want to select a more specific node and perhaps offer suggestions or link out to, e.g., MONDO's hierarchy. Alternatively, you could exclude subclass_of from the initial query results that are returned and then alert users to the option of choosing subclasses. I'm sure there are other options, but I think we need to identify the simplest fix and then fine-tune it over time.

@cbizon cbizon added the UI label Apr 14, 2024
@hina-shah hina-shah added help wanted Extra attention is needed enhancement New feature or request answer quality labels Oct 8, 2024
@hina-shah hina-shah added subclassing and removed help wanted Extra attention is needed labels Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants