Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable cpplint & eslint on Actions for Linux platform #1056

Closed
minggangw opened this issue Mar 4, 2025 · 0 comments · Fixed by #1057
Closed

Re-enable cpplint & eslint on Actions for Linux platform #1056

minggangw opened this issue Mar 4, 2025 · 0 comments · Fixed by #1057
Assignees
Labels

Comments

@minggangw
Copy link
Member

No description provided.

@minggangw minggangw added the ci label Mar 4, 2025
@minggangw minggangw self-assigned this Mar 4, 2025
minggangw added a commit to minggangw/rclnodejs-1 that referenced this issue Mar 4, 2025
minggangw added a commit that referenced this issue Mar 5, 2025
This patch migrates `ESLint` configuration, `.eslintrc.yml` to [the new flat config format](https://eslint.org/docs/latest/use/configure/migration-guide) by creating `eslint.config.mjs`, meanwhile, re-enables [cpplint](https://github.com/cpplint/cpplint) for Linux platform actions, including:

1. Config `eslint` using recommended configs for `*.js` files in`eslint.config.mjs`.
2. Config `eslint-plugin-prettier` using recommended configs for `*.js` files in `eslint.config.mjs`.
3. Config `@typescript-eslint/eslint-plugin` using recommended configs for `*.d.ts` files in `eslint.config.mjs`.
4. Re-enable [`cpplint.py`](https://github.com/cpplint/cpplint/blob/develop/cpplint.py) for `*.{hpp,cpp}` files.
5. Fix errors/warnings reported by linters above.
6. Add `npm run lint` as addition step for actions, `.github/workflows/linux-build-and-test-compatibility.yml` and `.github/workflows/linux-build-and-test.yml`.
7. Remove original `.eslintrc.yml`.

Fix: #1056
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant