v1.37.1 (#602)

Co-authored-by: Allan RIbeiro <[email protected]>

Author: d-gubert

package-lock.json

@@ -1,6 +1,6 @@
 {
     "name": "@rocket.chat/apps-engine",
-    "version": "1.37.0",
+    "version": "1.37.1",
     "description": "The engine code for the Rocket.Chat Apps which manages, runs, translates, coordinates and all of that.",
     "main": "index",
     "typings": "index",

package.json

@@ -11,4 +11,19 @@
  * that a user cannot perform some action, e.g.
  * join a room
  */
-export class AppsEngineException extends Error {}
+export class AppsEngineException extends Error {
+    public name = 'AppsEngineException';
+    public message: string;
+
+    constructor(message?: string) {
+        super();
+        this.message = message;
+    }
+
+    public getErrorInfo() {
+        return {
+            name: this.name,
+            message: this.message,
+        };
+    }
+}

src/definition/exceptions/AppsEngineException.ts

@@ -64,8 +64,7 @@ export class ProxiedApp implements IApp {
 
     public async call(method: AppMethod, ...args: Array<any>): Promise<any> {
         if (typeof (this.app as any)[method] !== 'function') {
-            throw new Error(`The App ${this.app.getName()} (${this.app.getID()}`
-                + ` does not have the method: "${method}"`);
+            throw new Error(`The App ${this.app.getName()} (${this.app.getID()}` + ` does not have the method: "${method}"`);
         }
 
         // tslint:disable-next-line
@@ -79,16 +78,14 @@ export class ProxiedApp implements IApp {
 
         let result;
         try {
-            result = await this.runtime.runInSandbox(
-                `module.exports = app.${method}.apply(app, args)`,
-                { app: this.app, args },
-            );
+            result = await this.runtime.runInSandbox(`module.exports = app.${method}.apply(app, args)`, { app: this.app, args });
             logger.debug(`'${method}' was successfully called! The result is:`, result);
         } catch (e) {
             logger.error(e);
             logger.debug(`'${method}' was unsuccessful.`);
 
-            if (e instanceof AppsEngineException) {
+            const errorInfo = new AppsEngineException(e.message).getErrorInfo();
+            if (e.name === errorInfo.name) {
                 throw e;
             }
         } finally {