Skip to content

Commit 39b05d5

Browse files
Corrections based on code review
1 parent fffd2b4 commit 39b05d5

File tree

2 files changed

+3
-6
lines changed

2 files changed

+3
-6
lines changed

src/sdl2/controller.rs

+2-2
Original file line numberDiff line numberDiff line change
@@ -574,7 +574,7 @@ impl GameController {
574574

575575
/// Send a controller specific effect packet.
576576
#[doc(alias = "SDL_GameControllerSendEffect")]
577-
pub fn send_effect(&mut self, data: &[u8]) -> Result<(), IntegerOrSdlError> {
577+
pub fn send_effect(&mut self, data: &[u8]) -> Result<(), String> {
578578
let result = unsafe {
579579
sys::SDL_GameControllerSendEffect(
580580
self.raw,
@@ -584,7 +584,7 @@ impl GameController {
584584
};
585585

586586
if result != 0 {
587-
Err(IntegerOrSdlError::SdlError(get_error()))
587+
Err(get_error())
588588
} else {
589589
Ok(())
590590
}

src/sdl2/video.rs

+1-4
Original file line numberDiff line numberDiff line change
@@ -1433,10 +1433,7 @@ impl Window {
14331433
pub fn icc_profile(&self) -> Result<Vec<u8>, String> {
14341434
unsafe {
14351435
let mut size: sys::size_t = 0;
1436-
let data = sys::SDL_GetWindowICCProfile(
1437-
self.context.raw,
1438-
&mut size as *const sys::size_t as *mut _,
1439-
);
1436+
let data = sys::SDL_GetWindowICCProfile(self.context.raw, &mut size as *mut _);
14401437
if data.is_null() {
14411438
return Err(get_error());
14421439
}

0 commit comments

Comments
 (0)