Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

des: tweak weak key test #468

Merged
merged 4 commits into from
Feb 14, 2025
Merged

des: tweak weak key test #468

merged 4 commits into from
Feb 14, 2025

Conversation

newpavlov
Copy link
Member

The new code results in a slightly better codegen while still being const time, including 32 bit targets: https://rust.godbolt.org/z/K7cjj5d1P

@newpavlov newpavlov requested review from tarcieri and baloo February 12, 2025 13:43
@newpavlov
Copy link
Member Author

@baloo
I am not sure what exact purpose of the bit counting loop was, so I removed it for now. Could you explain it?

@baloo
Copy link
Member

baloo commented Feb 12, 2025

That was a copy paste from https://github.com/iqlusioninc/yubikey.rs/blob/13bdf9a5850c124057825297b51eaecaf8ebe9e2/src/mgm/tdes.rs#L36
I think @str4d was the original author.

@newpavlov newpavlov merged commit 717c382 into master Feb 14, 2025
161 checks passed
@newpavlov newpavlov deleted the des/tweak_weak branch February 14, 2025 11:29
@newpavlov
Copy link
Member Author

I added subkey equality check for TDES in #470.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants