Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EAC-CPF (versions 2010 and 2018): is @localType optional in localControl or not? #153

Closed
2 of 9 tasks
fordmadox opened this issue Aug 9, 2020 · 4 comments
Closed
2 of 9 tasks

Comments

@fordmadox
Copy link
Member

Creator of issue

  1. Mark Custer.

The issue relates to

  • EAC-CPF schema issue
  • EAC-CPF Tag Library issue
  • EAD schema issue
  • EAD Tag Library issue
  • Schema issue
  • Tag Library issue
  • Suggestions for all schemas
  • Suggestions for all Tag Libraries
  • Other

Wanted change/feature

  • Text:

Reporting a bug

The tag library, however, says that this attribute is optional in localControl (as it is in EAD3). See https://github.com/SAA-SDT/EAS-TagLibraries/blob/master/tei/EAC-CPF-TL-eng.xml#L4398-L4399

Suggested Solution

  • Given this doesn't seem to be causing any issues, I'd ignore it. However, we could also release a patch for the schema or the tag library, if desired.

Steps to Reproduce (for bugs)

Context

  • Text:

Your Environment can be a clue to a bug

  • Version used:
  • Environment name and version (e.g. Chrome 39, node.js 5.4):
  • Operating System and version (desktop or mobile):
@kerstarno
Copy link
Contributor

See my comment to #105 - personally, I would not make @localType mandatory in any context.

@fordmadox
Copy link
Member Author

Right now, @localType is already required on localContext in the 2010/2018 versions of the EAC schema. We could issue a minor revision (e.g. EAC-CPF 1.2) to address that discrepancy in the tag library (and align with EAD3), but unless there is a community request to change it, I'd suggest we ignore this discrepancy and only address it in EAC 2.0.

@SJagodzinski
Copy link
Contributor

@fordmadox : Following my comment in #105 I'd like to anlign the schema and TL with EAD3. So, @localType and <term> are both defined as optional.

@fordmadox
Copy link
Member Author

Sounds good! I am going to close this issue, but please re-open if needed. I opened this issue for the current versions of EAC, but it sounds like there's no desire to issue a patch for those two versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants