Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Login Feature #28

Open
shilpi1958 opened this issue Mar 27, 2020 · 6 comments
Open

Login Feature #28

shilpi1958 opened this issue Mar 27, 2020 · 6 comments

Comments

@shilpi1958
Copy link
Contributor

shilpi1958 commented Mar 27, 2020

Login through the phone number

Login through Fb and Gmail will seriously limit our user base, as in our country a huge number of people using this service do not have access to tech, and our elders aren't tech-savvy enough to have FB/Gmail. An easier option would be login through your phone number, reaching everyone!>

Designing and adding functionality to solve this issue :)

@SAITARUN55
Copy link
Owner

would u like to work on this issue? If so, u hv to wait for some time... #23 This issue has to be merged first....then only u can start working...if u want to

@shilpi1958
Copy link
Contributor Author

Okay, I will go ahead with it once #23 is done! For now, I will integrate it into the design!

@khushbuThakker
Copy link
Contributor

@shilpi1958 and @SAITARUN55

I think we will have google and Facebook login after this pr merges, Can't we defer this after we have our first Proof of concept, as we have many other challenges like data managements and other station designs so i think we have to focus on that first..

@shilpi1958
Copy link
Contributor Author

shilpi1958 commented Mar 27, 2020

@khushbuThakker
The design principles absolutely prohibit adding such features later.

  1. You will have to change the login screen, have an additional verification screen for mobile number, changes in your profile page, the whole UI of the app will change, which is a burden for both designer and the developer.
  2. User always comes first . This is the first principle of the product. You cannot have the product which limits the user base quite directly. Ultimately you need users.

I say this as a product designer. Rest, of course, depends on the common consensus. I will be fine with whatever the team decides :)

@swathi-0901
Copy link

swathi-0901 commented Mar 29, 2020

Can I work this issue? with my teammate Bhavya

@SAITARUN55
Copy link
Owner

Nope @swathi-0901 the pr #23 has to be merged first then this can be taken...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants