Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TBI - Abstract some functionality from ui5-application-writer for reuse #1039

Closed
2 tasks
cianmSAP opened this issue May 26, 2023 · 0 comments
Closed
2 tasks
Assignees
Labels
project-access Tickets related to @sap-ux/project-access ui5-application-writer @sap-ux/ui5-application-writer ui5-config @sap-ux/ui5-config

Comments

@cianmSAP
Copy link
Contributor

cianmSAP commented May 26, 2023

Description (include screenshots)

As per #1008 (comment) , there are 3 functions that should not be exposed by ui5-application-writer but added to more common modules and consumed by the other writers.

  • move getFilePaths to the project-access module
  • getEsmTypesVersion, mergeObjects (UI5_DEFAULT enum?) to the ui5-config module

Value

Makes these functions available for more general use across the writer modules

Architecture Elaboration

Conversation in #1008 (comment)

Notes

Tasks

  • move getFilePaths to the project-access module
  • getEsmTypesVersion and mergeObjects to the ui5-config module
@cianmSAP cianmSAP added ui5-config @sap-ux/ui5-config ui5-application-writer @sap-ux/ui5-application-writer project-access Tickets related to @sap-ux/project-access labels May 26, 2023
@cianmSAP cianmSAP self-assigned this May 26, 2023
@cianmSAP cianmSAP closed this as completed Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
project-access Tickets related to @sap-ux/project-access ui5-application-writer @sap-ux/ui5-application-writer ui5-config @sap-ux/ui5-config
Projects
None yet
Development

No branches or pull requests

1 participant